fix(error-message): clean urls from 404 error#3732
Merged
wraithgar merged 1 commit intorelease-nextfrom Sep 9, 2021
Merged
Conversation
Member
Author
|
The wording was updated to not just say "npm registry" since this is just a generic 404 handler, it could be from any registry. |
nlf
approved these changes
Sep 9, 2021
Contributor
nlf
left a comment
There was a problem hiding this comment.
much better. i agree with the wording change here too 👍
If the package being installed is a url it needs to be cleaned before logging so passwords aren't potentially logged. PR-URL: #3732 Credit: @wraithgar Close: #3732 Reviewed-by: @nlf
e06e507 to
1ad0938
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the package being installed is a url it needs to be cleaned before
logging so passwords aren't potentially logged.