Pass full set of options to login helper functions

isaacs · isaacs · commit 9eef638499c8 · 2020-12-18T11:08:56.000-08:00
This fixes 'npm login --no-strict-ssl', as well as a host of other options that one might want to set while logging in. Reported by: @toddself
diff --git a/lib/adduser.js b/lib/adduser.js
@@ -59,6 +59,7 @@ const adduser = async (args) => {
   log.notice('', `Log in on ${replaceInfo(registry)}`)
 
   const { message, newCreds } = await auth({
+    ...npm.flatOptions,
     creds,
     registry,
     scope,
diff --git a/test/lib/adduser.js b/test/lib/adduser.js
@@ -9,21 +9,27 @@ const _flatOptions = {
   authType: 'legacy',
   registry: 'https://registry.npmjs.org/',
   scope: '',
+  fromFlatOptions: true,
 }
 
 let failSave = false
 let deletedConfig = {}
 let registryOutput = ''
 let setConfig = {}
-const authDummy = () => Promise.resolve({
-  message: 'success',
-  newCreds: {
-    username: 'u',
-    password: 'p',
-    email: 'u@npmjs.org',
-    alwaysAuth: false,
-  },
-})
+const authDummy = (options) => {
+  if (!options.fromFlatOptions)
+    throw new Error('did not pass full flatOptions to auth function')
+
+  return Promise.resolve({
+    message: 'success',
+    newCreds: {
+      username: 'u',
+      password: 'p',
+      email: 'u@npmjs.org',
+      alwaysAuth: false,
+    },
+  })
+}
 
 const deleteMock = (key, where) => {
   deletedConfig = {
