[fix] node v10.0 lacks fs.promises

ljharb · wraithgar · commit 868954a72c06 · 2021-02-12T09:35:10.000-08:00
In this node version, fall back to `util.promisify` of the callback version. Maybe fixes #2623. Maybe fixes #2652. Maybe fixes #2625. PR-URL: #2654 Credit: @ljharb Close: #2654 Reviewed-by: @wraithgar, @ruyadorno
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -41,7 +41,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [10.x, 12.x, 14.x]
+        node-version: ['10.1', 10.x, '12.1', 12.x, '14.1', 14.x]
         platform:
           - os: ubuntu-latest
             shell: bash
diff --git a/lib/shrinkwrap.js b/lib/shrinkwrap.js
@@ -1,5 +1,7 @@
 const { resolve, basename } = require('path')
-const { promises: { unlink } } = require('fs')
+const util = require('util')
+const fs = require('fs')
+const { unlink } = fs.promises || util.promisify(fs.unlink)
 const Arborist = require('@npmcli/arborist')
 const log = require('npmlog')
 
diff --git a/lib/utils/reify-finish.js b/lib/utils/reify-finish.js
@@ -1,7 +1,9 @@
 const reifyOutput = require('./reify-output.js')
 const npm = require('../npm.js')
 const ini = require('ini')
-const {writeFile} = require('fs').promises
+const util = require('util')
+const fs = require('fs')
+const { writeFile } = fs.promises || { writeFile: util.promisify(fs.writeFile) }
 const {resolve} = require('path')
 
 const reifyFinish = async arb => {
diff --git a/test/lib/shrinkwrap.js b/test/lib/shrinkwrap.js
@@ -1,4 +1,5 @@
 const t = require('tap')
+const fs = require('fs')
 const requireInject = require('require-inject')
 
 const npm = {
@@ -327,3 +328,10 @@ t.test('shrinkwrap --global', t => {
     t.end()
   })
 })
+
+t.test('works without fs.promises', async t => {
+  t.doesNotThrow(() => requireInject('../../lib/shrinkwrap.js', {
+    ...mocks,
+    fs: { ...fs, promises: null },
+  }))
+})
diff --git a/test/lib/utils/reify-finish.js b/test/lib/utils/reify-finish.js
@@ -20,7 +20,7 @@ let expectWrite = false
 const realFs = require('fs')
 const fs = {
   ...realFs,
-  promises: {
+  promises: realFs.promises && {
     ...realFs.promises,
     writeFile: async (path, data) => {
       if (!expectWrite)
@@ -78,3 +78,11 @@ t.test('should write if everything above passes', async t => {
   const data = fs.readFileSync(`${path}/npmrc`, 'utf8').replace(/\r\n/g, '\n')
   t.matchSnapshot(data, 'written config')
 })
+
+t.test('works without fs.promises', async t => {
+  t.doesNotThrow(() => requireInject('../../../lib/utils/reify-finish.js', {
+    fs: { ...fs, promises: null },
+    '../../../lib/npm.js': npm,
+    '../../../lib/utils/reify-output.js': reifyOutput,
+  }))
+})
