Remove ordinal comparer passed into Dictionary (#5400)

NinoFloris · web-flow · commit f25ff29e0979 · 2023-11-19T19:33:18.000+01:00
diff --git a/src/Npgsql/NpgsqlParameterCollection.cs b/src/Npgsql/NpgsqlParameterCollection.cs
@@ -404,7 +404,7 @@ public override int IndexOf(string parameterName)
         void BuildLookup()
         {
             if (TwoPassCompatMode)
-                _caseSensitiveLookup = new Dictionary<string, int>(InternalList.Count, StringComparer.Ordinal);
+                _caseSensitiveLookup = new Dictionary<string, int>(InternalList.Count);
 
             _caseInsensitiveLookup = new Dictionary<string, int>(InternalList.Count, StringComparer.OrdinalIgnoreCase);
 
@@ -674,7 +674,7 @@ internal void CloneTo(NpgsqlParameterCollection other)
             if (TwoPassCompatMode)
             {
                 Debug.Assert(_caseSensitiveLookup is not null);
-                other._caseSensitiveLookup = new Dictionary<string, int>(_caseSensitiveLookup, StringComparer.Ordinal);
+                other._caseSensitiveLookup = new Dictionary<string, int>(_caseSensitiveLookup);
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ public override int IndexOf(string parameterName)`
`404`	`404`	`void BuildLookup()`
`405`	`405`	`{`
`406`	`406`	`if (TwoPassCompatMode)`
`407`		`- _caseSensitiveLookup = new Dictionary<string, int>(InternalList.Count, StringComparer.Ordinal);`
	`407`	`+ _caseSensitiveLookup = new Dictionary<string, int>(InternalList.Count);`
`408`	`408`
`409`	`409`	`_caseInsensitiveLookup = new Dictionary<string, int>(InternalList.Count, StringComparer.OrdinalIgnoreCase);`
`410`	`410`
`@@ -674,7 +674,7 @@ internal void CloneTo(NpgsqlParameterCollection other)`
`674`	`674`	`if (TwoPassCompatMode)`
`675`	`675`	`{`
`676`	`676`	`Debug.Assert(_caseSensitiveLookup is not null);`
`677`		`- other._caseSensitiveLookup = new Dictionary<string, int>(_caseSensitiveLookup, StringComparer.Ordinal);`
	`677`	`+ other._caseSensitiveLookup = new Dictionary<string, int>(_caseSensitiveLookup);`
`678`	`678`	`}`
`679`	`679`	`}`
`680`	`680`	`}`