Bump SDK and dependencies to 8.0 GA (#5397)

roji · web-flow · commit dd2ed815b3a7 · 2023-11-14T19:28:55.000Z
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  dotnet_sdk_version: '8.0.100-rc.2.23502.2'
+  dotnet_sdk_version: '8.0.100'
   postgis_version: 3
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
   # Windows comes with PG pre-installed, and defines the PGPASSWORD environment variable. Remove it as it interferes
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -32,7 +32,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  dotnet_sdk_version: '8.0.100-rc.2.23502.2'
+  dotnet_sdk_version: '8.0.100'
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
 
 jobs:
diff --git a/.github/workflows/native-aot.yml b/.github/workflows/native-aot.yml
@@ -15,7 +15,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  dotnet_sdk_version: '8.0.100-rc.2.23502.2'
+  dotnet_sdk_version: '8.0.100'
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
   # Uncomment and edit the following to use nightly/preview builds 
 #  nuget_config: |
diff --git a/.github/workflows/rich-code-nav.yml b/.github/workflows/rich-code-nav.yml
@@ -9,7 +9,7 @@ on:
       - '*'
 
 env:
-  dotnet_sdk_version: '8.0.100-rc.2.23502.2'
+  dotnet_sdk_version: '8.0.100'
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
 
 jobs:
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <SystemVersion>8.0.0-rc.2.23479.6</SystemVersion>
+    <SystemVersion>8.0.0</SystemVersion>
     <ExtensionsVersion>$(SystemVersion)</ExtensionsVersion>
   </PropertyGroup>
   
diff --git a/global.json b/global.json
@@ -2,6 +2,6 @@
   "sdk": {
     "version": "8.0.100",
     "rollForward": "latestMajor",
-    "allowPrerelease": "true"
+    "allowPrerelease": "false"
   }
 }
diff --git a/src/Npgsql.GeoJSON/Internal/GeoJSONConverter.cs b/src/Npgsql.GeoJSON/Internal/GeoJSONConverter.cs
@@ -294,7 +294,8 @@ double ReadDouble(bool littleEndian)
             {
                 if (littleEndian)
                 {
-                    var value = BinaryPrimitives.ReverseEndianness(Unsafe.As<double, long>(ref Unsafe.AsRef(reader.ReadDouble())));
+                    var doubleValue = reader.ReadDouble();
+                    var value = BinaryPrimitives.ReverseEndianness(Unsafe.As<double, long>(ref doubleValue));
                     return Unsafe.As<long, double>(ref value);
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,6 @@`
`2`	`2`	`"sdk": {`
`3`	`3`	`"version": "8.0.100",`
`4`	`4`	`"rollForward": "latestMajor",`
`5`		`- "allowPrerelease": "true"`
	`5`	`+ "allowPrerelease": "false"`
`6`	`6`	`}`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,8 @@ double ReadDouble(bool littleEndian)`
`294`	`294`	`{`
`295`	`295`	`if (littleEndian)`
`296`	`296`	`{`
`297`		`- var value = BinaryPrimitives.ReverseEndianness(Unsafe.As<double, long>(ref Unsafe.AsRef(reader.ReadDouble())));`
	`297`	`+ var doubleValue = reader.ReadDouble();`
	`298`	`+ var value = BinaryPrimitives.ReverseEndianness(Unsafe.As<double, long>(ref doubleValue));`
`298`	`299`	`return Unsafe.As<long, double>(ref value);`
`299`	`300`	`}`
`300`	`301`