Move case insensitive lookup to use Ordinal comparison (#3690)

NinoFloris · web-flow · commit b4ead6c0f8ff · 2021-04-29T08:01:18.000+03:00
diff --git a/src/Npgsql/NpgsqlParameterCollection.cs b/src/Npgsql/NpgsqlParameterCollection.cs
@@ -269,7 +269,7 @@ public override int IndexOf(string parameterName)
                 // Case sensitive lookup failed, generate a case insensitive lookup
                 if (_lookupIgnoreCase == null)
                 {
-                    _lookupIgnoreCase = new Dictionary<string, int>(PGUtil.InvariantCaseIgnoringStringComparer);
+                    _lookupIgnoreCase = new Dictionary<string, int>(_internalList.Count, StringComparer.OrdinalIgnoreCase);
                     for (var i = 0 ; i < _internalList.Count ; i++)
                     {
                         var item = _internalList[i];
diff --git a/src/Npgsql/Util/PGUtil.cs b/src/Npgsql/Util/PGUtil.cs
@@ -118,8 +118,6 @@ internal static int RotateShift(int val, int shift)
 
         internal static readonly Task<bool> TrueTask = Task.FromResult(true);
         internal static readonly Task<bool> FalseTask = Task.FromResult(false);
-
-        internal static StringComparer InvariantCaseIgnoringStringComparer => StringComparer.InvariantCultureIgnoreCase;
     }
 
     enum FormatCode : short

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ public override int IndexOf(string parameterName)`
`269`	`269`	`// Case sensitive lookup failed, generate a case insensitive lookup`
`270`	`270`	`if (_lookupIgnoreCase == null)`
`271`	`271`	`{`
`272`		`- _lookupIgnoreCase = new Dictionary<string, int>(PGUtil.InvariantCaseIgnoringStringComparer);`
	`272`	`+ _lookupIgnoreCase = new Dictionary<string, int>(_internalList.Count, StringComparer.OrdinalIgnoreCase);`
`273`	`273`	`for (var i = 0 ; i < _internalList.Count ; i++)`
`274`	`274`	`{`
`275`	`275`	`var item = _internalList[i];`
Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,6 @@ internal static int RotateShift(int val, int shift)`
`118`	`118`
`119`	`119`	`internal static readonly Task<bool> TrueTask = Task.FromResult(true);`
`120`	`120`	`internal static readonly Task<bool> FalseTask = Task.FromResult(false);`
`121`		`-`
`122`		`- internal static StringComparer InvariantCaseIgnoringStringComparer => StringComparer.InvariantCultureIgnoreCase;`
`123`	`121`	`}`
`124`	`122`
`125`	`123`	`enum FormatCode : short`