Revert tests

NinoFloris · NinoFloris · commit 102d263251e8 · 2026-04-08T00:29:26.000+02:00
diff --git a/test/Npgsql.Tests/Types/ArrayTests.cs b/test/Npgsql.Tests/Types/ArrayTests.cs
@@ -6,9 +6,7 @@
 using System.Diagnostics;
 using System.Text;
 using System.Threading.Tasks;
-using Npgsql.Internal;
 using Npgsql.Internal.Converters;
-using Npgsql.Internal.Postgres;
 using NpgsqlTypes;
 using NUnit.Framework;
 using static Npgsql.Tests.TestUtil;
@@ -503,30 +501,6 @@ public async Task Generics_read_empty_multidim_array()
         Assert.That(reader.GetFieldValue<int[,]>(0).Length, Is.Zero);
     }
 
-    [Test]
-    public async Task Nullable_array_write_state_flows([Values] bool fixedSize)
-    {
-        // Verifies that provider-produced write state flows through IsDbNull and Write
-        // for nullable array elements, both fixed-size and variable-size.
-        var dataSourceBuilder = new NpgsqlSlimDataSourceBuilder(ConnectionString);
-        dataSourceBuilder.EnableArrays();
-        dataSourceBuilder.AddTypeInfoResolverFactory(new WriteStateTrackingResolverFactory(fixedSize));
-        await using var dataSource = dataSourceBuilder.Build();
-        await using var conn = await dataSource.OpenConnectionAsync();
-
-        WriteStateTrackingConverter.Reset();
-
-        var input = new[] { 1, 2, 3 };
-
-        await using var cmd = new NpgsqlCommand("SELECT @p", conn);
-        cmd.Parameters.Add(new NpgsqlParameter<int[]> { ParameterName = "p", TypedValue = input, DataTypeName = "integer[]" });
-        await cmd.ExecuteNonQueryAsync();
-
-        if (fixedSize)
-            Assert.That(WriteStateTrackingConverter.IsDbNullWriteStateReceived, Is.True, "IsDbNullValue did not receive write state");
-        Assert.That(WriteStateTrackingConverter.WriteWriteStateReceived, Is.True, "Write did not receive write state");
-    }
-
     [Test]
     public async Task Arrays_not_supported_by_default_on_NpgsqlSlimSourceBuilder()
     {
@@ -547,90 +521,3 @@ public async Task NpgsqlSlimSourceBuilder_EnableArrays()
         await AssertType(dataSource, new[] { 1, 2, 3 }, "{1,2,3}", "integer[]");
     }
 }
-
-sealed class WriteStateTrackingConverter(bool fixedSize) : PgBufferedConverter<int>(customDbNullPredicate: true)
-{
-    internal static bool IsDbNullWriteStateReceived;
-    internal static bool WriteWriteStateReceived;
-
-    internal static void Reset()
-    {
-        IsDbNullWriteStateReceived = false;
-        WriteWriteStateReceived = false;
-    }
-
-    public override bool CanConvert(DataFormat format, out BufferRequirements bufferRequirements)
-    {
-        bufferRequirements = fixedSize ? BufferRequirements.CreateFixedSize(sizeof(int)) : BufferRequirements.Create(Size.CreateUpperBound(sizeof(int)));
-        return format is DataFormat.Binary;
-    }
-
-    protected override bool IsDbNullValue(int value, object? writeState)
-    {
-        if (writeState is not null)
-            IsDbNullWriteStateReceived = true;
-        return false;
-    }
-
-    protected override int ReadCore(PgReader reader) => reader.ReadInt32();
-
-    protected override void WriteCore(PgWriter writer, int value)
-    {
-        if (writer.Current.WriteState is not null)
-            WriteWriteStateReceived = true;
-        writer.WriteInt32(value);
-    }
-
-    public override Size GetSize(SizeContext context, int value, ref object? writeState)
-        => sizeof(int);
-}
-
-sealed class WriteStateTrackingProvider(PgSerializerOptions options, bool fixedSize) : PgConcreteTypeInfoProvider<int>
-{
-    PgConcreteTypeInfo? _concreteTypeInfo;
-
-    PgConcreteTypeInfo GetOrCreate()
-        => _concreteTypeInfo ??= new(options, new WriteStateTrackingConverter(fixedSize), options.GetCanonicalTypeId(DataTypeNames.Int4));
-
-    protected override PgConcreteTypeInfo GetDefaultCore(PgTypeId? pgTypeId) => GetOrCreate();
-
-    protected override PgConcreteTypeInfo? GetForValueCore(ProviderValueContext context, int value, ref object? writeState)
-    {
-        writeState = "provider-state";
-        return GetOrCreate();
-    }
-}
-
-sealed class WriteStateTrackingResolverFactory(bool fixedSize) : PgTypeInfoResolverFactory
-{
-    public override IPgTypeInfoResolver CreateResolver() => new Resolver(fixedSize);
-    public override IPgTypeInfoResolver CreateArrayResolver() => new ArrayResolver();
-
-    sealed class Resolver(bool fixedSize) : IPgTypeInfoResolver
-    {
-        public PgTypeInfo? GetTypeInfo(Type? type, DataTypeName? dataTypeName, PgSerializerOptions options)
-        {
-            if (dataTypeName == DataTypeNames.Int4 && (type == typeof(int) || type is null))
-                return new PgProviderTypeInfo(options, new WriteStateTrackingProvider(options, fixedSize), DataTypeNames.Int4);
-
-            return null;
-        }
-    }
-
-    sealed class ArrayResolver : IPgTypeInfoResolver
-    {
-        public PgTypeInfo? GetTypeInfo(Type? type, DataTypeName? dataTypeName, PgSerializerOptions options)
-        {
-            if (dataTypeName != DataTypeNames.Int4.ToArrayName())
-                return null;
-
-            var elementInfo = options.GetTypeInfo(typeof(int), DataTypeNames.Int4);
-            if (elementInfo is not PgProviderTypeInfo providerTypeInfo)
-                return null;
-
-            return new PgProviderTypeInfo(options,
-                new ArrayTypeInfoProvider<int[], int>(providerTypeInfo, typeof(int[])),
-                dataTypeName);
-        }
-    }
-}
