Removed JetBrains annotations (#3360)

YohDeadfall · web-flow · commit 0c51805072d5 · 2020-11-19T12:28:54.000+03:00
Was replaced by nullability attributes previously.
diff --git a/src/Npgsql/NpgsqlBinaryImporter.cs b/src/Npgsql/NpgsqlBinaryImporter.cs
@@ -2,7 +2,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using System.Threading.Tasks;
-using JetBrains.Annotations;
 using Npgsql.BackendMessages;
 using Npgsql.Logging;
 using NpgsqlTypes;
diff --git a/src/Npgsql/NpgsqlConnection.cs b/src/Npgsql/NpgsqlConnection.cs
@@ -13,7 +13,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using System.Transactions;
-using JetBrains.Annotations;
 using Npgsql.Logging;
 using Npgsql.NameTranslation;
 using Npgsql.TypeMapping;
diff --git a/src/Npgsql/NpgsqlDataAdapter.cs b/src/Npgsql/NpgsqlDataAdapter.cs
@@ -3,7 +3,6 @@
 using System.Data.Common;
 using System.Threading;
 using System.Threading.Tasks;
-using JetBrains.Annotations;
 
 namespace Npgsql
 {
diff --git a/src/Npgsql/NpgsqlDataReader.cs b/src/Npgsql/NpgsqlDataReader.cs
@@ -11,7 +11,6 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-using JetBrains.Annotations;
 using Npgsql.BackendMessages;
 using Npgsql.Logging;
 using Npgsql.PostgresTypes;
diff --git a/src/Npgsql/NpgsqlParameter.cs b/src/Npgsql/NpgsqlParameter.cs
@@ -5,7 +5,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using System.Threading.Tasks;
-using JetBrains.Annotations;
 using Npgsql.PostgresTypes;
 using Npgsql.TypeHandling;
 using Npgsql.TypeMapping;
diff --git a/src/Npgsql/NpgsqlParameterCollection.cs b/src/Npgsql/NpgsqlParameterCollection.cs
@@ -3,7 +3,6 @@
 using System.Collections.Generic;
 using System.Data.Common;
 using System.Diagnostics.CodeAnalysis;
-using JetBrains.Annotations;
 using Npgsql.Util;
 using NpgsqlTypes;
 
diff --git a/src/Npgsql/NpgsqlTypes/NpgsqlDate.cs b/src/Npgsql/NpgsqlTypes/NpgsqlDate.cs
@@ -2,7 +2,6 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Text;
-using JetBrains.Annotations;
 
 #pragma warning disable 1591
 
diff --git a/src/Npgsql/PostgresException.cs b/src/Npgsql/PostgresException.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Runtime.Serialization;
 using System.Text;
-using JetBrains.Annotations;
 using Npgsql.BackendMessages;
 
 #pragma warning disable CA1032
diff --git a/src/Npgsql/PostgresNotice.cs b/src/Npgsql/PostgresNotice.cs
@@ -1,5 +1,4 @@
 ﻿using System;
-using JetBrains.Annotations;
 using Npgsql.BackendMessages;
 
 namespace Npgsql
diff --git a/src/Npgsql/PostgresTypes/PostgresArrayType.cs b/src/Npgsql/PostgresTypes/PostgresArrayType.cs
@@ -1,5 +1,4 @@
 ﻿using System.Diagnostics;
-using JetBrains.Annotations;
 
 namespace Npgsql.PostgresTypes
 {
diff --git a/src/Npgsql/PostgresTypes/PostgresDomainType.cs b/src/Npgsql/PostgresTypes/PostgresDomainType.cs
@@ -1,6 +1,4 @@
-﻿using JetBrains.Annotations;
-
-namespace Npgsql.PostgresTypes
+﻿namespace Npgsql.PostgresTypes
 {
     /// <summary>
     /// Represents a PostgreSQL domain type.
diff --git a/src/Npgsql/PostgresTypes/PostgresRangeType.cs b/src/Npgsql/PostgresTypes/PostgresRangeType.cs
@@ -1,6 +1,4 @@
-﻿using JetBrains.Annotations;
-
-namespace Npgsql.PostgresTypes
+﻿namespace Npgsql.PostgresTypes
 {
     /// <summary>
     /// Represents a PostgreSQL range data type.
diff --git a/src/Npgsql/PostgresTypes/PostgresType.cs b/src/Npgsql/PostgresTypes/PostgresType.cs
@@ -1,6 +1,4 @@
-﻿using JetBrains.Annotations;
-
-namespace Npgsql.PostgresTypes
+﻿namespace Npgsql.PostgresTypes
 {
     /// <summary>
     /// Represents a PostgreSQL data type, such as int4 or text, as discovered from pg_type.
diff --git a/src/Npgsql/Replication/ReplicationSlotOptions.cs b/src/Npgsql/Replication/ReplicationSlotOptions.cs
@@ -1,6 +1,5 @@
-﻿using JetBrains.Annotations;
+﻿using System;
 using NpgsqlTypes;
-using System;
 
 namespace Npgsql.Replication
 {
diff --git a/src/Npgsql/Replication/XLogDataMessage.cs b/src/Npgsql/Replication/XLogDataMessage.cs
@@ -1,7 +1,6 @@
-﻿using JetBrains.Annotations;
-using NpgsqlTypes;
-using System;
+﻿using System;
 using System.IO;
+using NpgsqlTypes;
 
 namespace Npgsql.Replication
 {
diff --git a/src/Npgsql/Schema/NpgsqlDbColumn.cs b/src/Npgsql/Schema/NpgsqlDbColumn.cs
@@ -1,7 +1,6 @@
 ﻿using System;
 using System.Data.Common;
 using System.Runtime.CompilerServices;
-using JetBrains.Annotations;
 using Npgsql.PostgresTypes;
 using NpgsqlTypes;
 
diff --git a/src/Npgsql/TypeMapping/INpgsqlTypeMapper.cs b/src/Npgsql/TypeMapping/INpgsqlTypeMapper.cs
@@ -1,6 +1,5 @@
 ﻿using System;
 using System.Collections.Generic;
-using JetBrains.Annotations;
 using Npgsql.NameTranslation;
 using NpgsqlTypes;
 
@@ -19,28 +18,24 @@ public interface INpgsqlTypeMapper
         /// <summary>
         /// The default name translator to convert CLR type names and member names.
         /// </summary>
-        [NotNull]
         INpgsqlNameTranslator DefaultNameTranslator { get; }
 
         /// <summary>
         /// Enumerates all mappings currently set up on this type mapper.
         /// </summary>
-        [NotNull]
-        [ItemNotNull]
         IEnumerable<NpgsqlTypeMapping> Mappings { get; }
 
         /// <summary>
         /// Adds a new type mapping to this mapper, overwriting any existing mapping in the process.
         /// </summary>
-        [NotNull]
-        INpgsqlTypeMapper AddMapping([NotNull] NpgsqlTypeMapping mapping);
+        INpgsqlTypeMapper AddMapping(NpgsqlTypeMapping mapping);
 
         /// <summary>
         /// Removes an existing mapping from this mapper. Attempts to read or write this type
         /// after removal will result in an exception.
         /// </summary>
         /// <param name="pgTypeName">A PostgreSQL type name for the type in the database.</param>
-        bool RemoveMapping([NotNull] string pgTypeName);
+        bool RemoveMapping(string pgTypeName);
 
         /// <summary>
         /// Maps a CLR enum to a PostgreSQL enum type.
@@ -62,7 +57,6 @@ public interface INpgsqlTypeMapper
         /// Defaults to <see cref="NpgsqlSnakeCaseNameTranslator"/>
         /// </param>
         /// <typeparam name="TEnum">The .NET enum type to be mapped</typeparam>
-        [NotNull]
         INpgsqlTypeMapper MapEnum<TEnum>(
             string? pgName = null,
             INpgsqlNameTranslator? nameTranslator = null)
@@ -104,7 +98,6 @@ bool UnmapEnum<TEnum>(
         /// Defaults to <see cref="NpgsqlSnakeCaseNameTranslator"/>
         /// </param>
         /// <typeparam name="T">The .NET type to be mapped</typeparam>
-        [NotNull]
         INpgsqlTypeMapper MapComposite<T>(
             string? pgName = null,
             INpgsqlNameTranslator? nameTranslator = null);
@@ -143,7 +136,6 @@ bool UnmapComposite<T>(
         /// A component which will be used to translate CLR names (e.g. SomeClass) into database names (e.g. some_class).
         /// Defaults to <see cref="NpgsqlSnakeCaseNameTranslator"/>
         /// </param>
-        [NotNull]
         INpgsqlTypeMapper MapComposite(
             Type clrType,
             string? pgName = null,
diff --git a/src/Npgsql/TypeMapping/TypeMappingAttribute.cs b/src/Npgsql/TypeMapping/TypeMappingAttribute.cs
@@ -2,13 +2,11 @@
 using System.Data;
 using System.Linq;
 using System.Text;
-using JetBrains.Annotations;
 using NpgsqlTypes;
 
 namespace Npgsql.TypeMapping
 {
     [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]
-    [MeansImplicitUse]
     class TypeMappingAttribute : Attribute
     {
         /// <summary>
diff --git a/src/Npgsql/Util/CodeAnnotations.cs b/src/Npgsql/Util/CodeAnnotations.cs

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`using System.Data.Common;`
`4`	`4`	`using System.Threading;`
`5`	`5`	`using System.Threading.Tasks;`
`6`		`-using JetBrains.Annotations;`
`7`	`6`
`8`	`7`	`namespace Npgsql`
`9`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System;`
`2`		`-using JetBrains.Annotations;`
`3`	`2`	`using Npgsql.BackendMessages;`
`4`	`3`
`5`	`4`	`namespace Npgsql`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System.Diagnostics;`
`2`		`-using JetBrains.Annotations;`
`3`	`2`
`4`	`3`	`namespace Npgsql.PostgresTypes`
`5`	`4`	`{`