fs: don't hard code name in validatePosition()

cjihrig · guangwong · commit 83de22fd37a4 · 2023-01-03T12:04:42.000+08:00
The name of the position being validated by validatePosition() was not being used. Instead, the string 'position' was being used everywhere. It worked out because the only call sites were using the name 'position' as well. PR-URL: nodejs/node#44767 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -903,17 +903,15 @@ const validatePrimitiveStringAfterArrayBufferView = hideStackFrames((buffer, nam
 
 const validatePosition = hideStackFrames((position, name) => {
   if (typeof position === 'number') {
-    validateInteger(position, 'position');
+    validateInteger(position, name);
   } else if (typeof position === 'bigint') {
     if (!(position >= -(2n ** 63n) && position <= 2n ** 63n - 1n)) {
-      throw new ERR_OUT_OF_RANGE('position',
+      throw new ERR_OUT_OF_RANGE(name,
                                  `>= ${-(2n ** 63n)} && <= ${2n ** 63n - 1n}`,
                                  position);
     }
   } else {
-    throw new ERR_INVALID_ARG_TYPE('position',
-                                   ['integer', 'bigint'],
-                                   position);
+    throw new ERR_INVALID_ARG_TYPE(name, ['integer', 'bigint'], position);
   }
 });
 
