Skip to content

Security Update broke test/fetch/pull-dont-push.js? #2697

Closed

Description

@Uzlopak

The unit test test/fetch/pull-dont-push.js is broken. I first thought it has something to do within my PR #2696 were I saw this first. But this issue is also on the default branch. I deleted locally my undici repo, cloned again and again the test runner hangs on this specific test.

I guess it has something to do with the security patches.

Activity

  1. mcollina commented on Feb 5, 2024

    @mcollina
    SponsorMember

    That test was added by the security release and it's passing on main. Where is it failing?

  2. Uzlopak commented on Feb 5, 2024

    @Uzlopak
    ContributorAuthor

    @mcollina
    Like i said, my pr is failing because if this file. And when i clone this repo fresh and use the main branch and install everything etc.. then this test is never ending?!

  3. Uzlopak commented on Feb 5, 2024

    @Uzlopak
    ContributorAuthor
  4. mcollina commented on Feb 5, 2024

    @mcollina
    SponsorMember

    The tests seems to be passing on main. Or maybe they are not run at all?

    On Mac the test pass on all version.

  5. Uzlopak commented on Feb 5, 2024

    @Uzlopak
    ContributorAuthor

    This one PR I created is just adding an .npmrc file and the CI/CD pipeline is broken?!

    Maybe one of the commits merged after the security release broke it?

    I will investigate in few hours.

  6. mcollina commented on Feb 5, 2024

    @mcollina
    SponsorMember

    Here is the fix: #2699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions