Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 9fa9559

Browse files
EmmaDawsonDevEmmaDawsonDev
authored
Fix: footer a11y (#2810)
* Update aria-labels for footer links * Regenerate snapshots
1 parent a53f94b commit 9fa9559

8 files changed

Lines changed: 36 additions & 79 deletions

File tree

‎src/components/Footer/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ exports[`Tests for Footer component renders correctly 1`] = `
1010
>
1111
<li>
1212
<a
13-
aria-label="Node.js Slack Link"
13+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
1414
class="link"
1515
href="https://trademark-policy.openjsf.org/"
1616
rel="noopener noreferrer"
@@ -68,16 +68,11 @@ exports[`Tests for Footer component renders correctly 1`] = `
6868
</li>
6969
<li>
7070
<a
71-
aria-label="Node.js Github Page Link"
71+
aria-label="Node.js Github Page (opens in new tab)"
7272
href="https://github.com/nodejs/node"
7373
rel="noopener noreferrer"
7474
target="_blank"
7575
>
76-
<span
77-
class="sr-only"
78-
>
79-
GitHub
80-
</span>
8176
<svg
8277
aria-hidden="true"
8378
class="svg-inline--fa fa-github "
@@ -98,7 +93,7 @@ exports[`Tests for Footer component renders correctly 1`] = `
9893
</li>
9994
<li>
10095
<a
101-
aria-label="Node.js Twitter Link"
96+
aria-label="Node.js Twitter (opens in new tab)"
10297
href="https://twitter.com/nodejs"
10398
rel="noopener noreferrer"
10499
target="_blank"
@@ -123,7 +118,7 @@ exports[`Tests for Footer component renders correctly 1`] = `
123118
</li>
124119
<li>
125120
<a
126-
aria-label="Node.js Slack Link"
121+
aria-label="Node.js Slack (opens in new tab)"
127122
href="https://slack.openjsf.org"
128123
rel="noopener noreferrer"
129124
target="_blank"

‎src/components/Footer/index.tsx‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const Footer = (): JSX.Element => (
1818
target="_blank"
1919
href="https://trademark-policy.openjsf.org/"
2020
rel="noopener noreferrer"
21-
aria-label="Node.js Slack Link"
21+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
2222
>
2323
<FormattedMessage id="components.footer.links.trademark" />
2424
</a>
@@ -61,11 +61,8 @@ const Footer = (): JSX.Element => (
6161
target="_blank"
6262
href="https://github.com/nodejs/node"
6363
rel="noopener noreferrer"
64-
aria-label="Node.js Github Page Link"
64+
aria-label="Node.js Github Page (opens in new tab)"
6565
>
66-
<span className="sr-only">
67-
<FormattedMessage id="components.footer.links.github" />
68-
</span>
6966
<FontAwesomeIcon
7067
icon={faGithub}
7168
color="var(--color-text-secondary)"
@@ -77,7 +74,7 @@ const Footer = (): JSX.Element => (
7774
target="_blank"
7875
href="https://twitter.com/nodejs"
7976
rel="noopener noreferrer"
80-
aria-label="Node.js Twitter Link"
77+
aria-label="Node.js Twitter (opens in new tab)"
8178
>
8279
<FontAwesomeIcon
8380
icon={faTwitter}
@@ -90,7 +87,7 @@ const Footer = (): JSX.Element => (
9087
target="_blank"
9188
href="https://slack.openjsf.org"
9289
rel="noopener noreferrer"
93-
aria-label="Node.js Slack Link"
90+
aria-label="Node.js Slack (opens in new tab)"
9491
>
9592
<FontAwesomeIcon icon={faSlack} color="var(--color-text-secondary)" />
9693
</a>

‎src/components/Layout/__tests__/__snapshots__/page.test.tsx.snap‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ exports[`PageLayout component renders correctly with data 1`] = `
331331
>
332332
<li>
333333
<a
334-
aria-label="Node.js Slack Link"
334+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
335335
class="link"
336336
href="https://trademark-policy.openjsf.org/"
337337
rel="noopener noreferrer"
@@ -389,16 +389,11 @@ exports[`PageLayout component renders correctly with data 1`] = `
389389
</li>
390390
<li>
391391
<a
392-
aria-label="Node.js Github Page Link"
392+
aria-label="Node.js Github Page (opens in new tab)"
393393
href="https://github.com/nodejs/node"
394394
rel="noopener noreferrer"
395395
target="_blank"
396396
>
397-
<span
398-
class="sr-only"
399-
>
400-
GitHub
401-
</span>
402397
<svg
403398
aria-hidden="true"
404399
class="svg-inline--fa fa-github "
@@ -419,7 +414,7 @@ exports[`PageLayout component renders correctly with data 1`] = `
419414
</li>
420415
<li>
421416
<a
422-
aria-label="Node.js Twitter Link"
417+
aria-label="Node.js Twitter (opens in new tab)"
423418
href="https://twitter.com/nodejs"
424419
rel="noopener noreferrer"
425420
target="_blank"
@@ -444,7 +439,7 @@ exports[`PageLayout component renders correctly with data 1`] = `
444439
</li>
445440
<li>
446441
<a
447-
aria-label="Node.js Slack Link"
442+
aria-label="Node.js Slack (opens in new tab)"
448443
href="https://slack.openjsf.org"
449444
rel="noopener noreferrer"
450445
target="_blank"

‎src/pages/about/__tests__/__snapshots__/resources.test.tsx.snap‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ exports[`Resources page renders correctly 1`] = `
462462
>
463463
<li>
464464
<a
465-
aria-label="Node.js Slack Link"
465+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
466466
class="link"
467467
href="https://trademark-policy.openjsf.org/"
468468
rel="noopener noreferrer"
@@ -520,16 +520,11 @@ exports[`Resources page renders correctly 1`] = `
520520
</li>
521521
<li>
522522
<a
523-
aria-label="Node.js Github Page Link"
523+
aria-label="Node.js Github Page (opens in new tab)"
524524
href="https://github.com/nodejs/node"
525525
rel="noopener noreferrer"
526526
target="_blank"
527527
>
528-
<span
529-
class="sr-only"
530-
>
531-
GitHub
532-
</span>
533528
<svg
534529
aria-hidden="true"
535530
class="svg-inline--fa fa-github "
@@ -550,7 +545,7 @@ exports[`Resources page renders correctly 1`] = `
550545
</li>
551546
<li>
552547
<a
553-
aria-label="Node.js Twitter Link"
548+
aria-label="Node.js Twitter (opens in new tab)"
554549
href="https://twitter.com/nodejs"
555550
rel="noopener noreferrer"
556551
target="_blank"
@@ -575,7 +570,7 @@ exports[`Resources page renders correctly 1`] = `
575570
</li>
576571
<li>
577572
<a
578-
aria-label="Node.js Slack Link"
573+
aria-label="Node.js Slack (opens in new tab)"
579574
href="https://slack.openjsf.org"
580575
rel="noopener noreferrer"
581576
target="_blank"

‎src/pages/download/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ exports[`Download page renders correctly 1`] = `
801801
>
802802
<li>
803803
<a
804-
aria-label="Node.js Slack Link"
804+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
805805
class="link"
806806
href="https://trademark-policy.openjsf.org/"
807807
rel="noopener noreferrer"
@@ -859,16 +859,11 @@ exports[`Download page renders correctly 1`] = `
859859
</li>
860860
<li>
861861
<a
862-
aria-label="Node.js Github Page Link"
862+
aria-label="Node.js Github Page (opens in new tab)"
863863
href="https://github.com/nodejs/node"
864864
rel="noopener noreferrer"
865865
target="_blank"
866866
>
867-
<span
868-
class="sr-only"
869-
>
870-
GitHub
871-
</span>
872867
<svg
873868
aria-hidden="true"
874869
class="svg-inline--fa fa-github "
@@ -889,7 +884,7 @@ exports[`Download page renders correctly 1`] = `
889884
</li>
890885
<li>
891886
<a
892-
aria-label="Node.js Twitter Link"
887+
aria-label="Node.js Twitter (opens in new tab)"
893888
href="https://twitter.com/nodejs"
894889
rel="noopener noreferrer"
895890
target="_blank"
@@ -914,7 +909,7 @@ exports[`Download page renders correctly 1`] = `
914909
</li>
915910
<li>
916911
<a
917-
aria-label="Node.js Slack Link"
912+
aria-label="Node.js Slack (opens in new tab)"
918913
href="https://slack.openjsf.org"
919914
rel="noopener noreferrer"
920915
target="_blank"
@@ -1744,7 +1739,7 @@ exports[`Download page should handle LTS to Current switch 1`] = `
17441739
>
17451740
<li>
17461741
<a
1747-
aria-label="Node.js Slack Link"
1742+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
17481743
class="link"
17491744
href="https://trademark-policy.openjsf.org/"
17501745
rel="noopener noreferrer"
@@ -1802,16 +1797,11 @@ exports[`Download page should handle LTS to Current switch 1`] = `
18021797
</li>
18031798
<li>
18041799
<a
1805-
aria-label="Node.js Github Page Link"
1800+
aria-label="Node.js Github Page (opens in new tab)"
18061801
href="https://github.com/nodejs/node"
18071802
rel="noopener noreferrer"
18081803
target="_blank"
18091804
>
1810-
<span
1811-
class="sr-only"
1812-
>
1813-
GitHub
1814-
</span>
18151805
<svg
18161806
aria-hidden="true"
18171807
class="svg-inline--fa fa-github "
@@ -1832,7 +1822,7 @@ exports[`Download page should handle LTS to Current switch 1`] = `
18321822
</li>
18331823
<li>
18341824
<a
1835-
aria-label="Node.js Twitter Link"
1825+
aria-label="Node.js Twitter (opens in new tab)"
18361826
href="https://twitter.com/nodejs"
18371827
rel="noopener noreferrer"
18381828
target="_blank"
@@ -1857,7 +1847,7 @@ exports[`Download page should handle LTS to Current switch 1`] = `
18571847
</li>
18581848
<li>
18591849
<a
1860-
aria-label="Node.js Slack Link"
1850+
aria-label="Node.js Slack (opens in new tab)"
18611851
href="https://slack.openjsf.org"
18621852
rel="noopener noreferrer"
18631853
target="_blank"

‎src/pages/download/__tests__/__snapshots__/package-manager.test.tsx.snap‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ exports[`Package Manager Page renders correctly 1`] = `
463463
>
464464
<li>
465465
<a
466-
aria-label="Node.js Slack Link"
466+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
467467
class="link"
468468
href="https://trademark-policy.openjsf.org/"
469469
rel="noopener noreferrer"
@@ -521,16 +521,11 @@ exports[`Package Manager Page renders correctly 1`] = `
521521
</li>
522522
<li>
523523
<a
524-
aria-label="Node.js Github Page Link"
524+
aria-label="Node.js Github Page (opens in new tab)"
525525
href="https://github.com/nodejs/node"
526526
rel="noopener noreferrer"
527527
target="_blank"
528528
>
529-
<span
530-
class="sr-only"
531-
>
532-
GitHub
533-
</span>
534529
<svg
535530
aria-hidden="true"
536531
class="svg-inline--fa fa-github "
@@ -551,7 +546,7 @@ exports[`Package Manager Page renders correctly 1`] = `
551546
</li>
552547
<li>
553548
<a
554-
aria-label="Node.js Twitter Link"
549+
aria-label="Node.js Twitter (opens in new tab)"
555550
href="https://twitter.com/nodejs"
556551
rel="noopener noreferrer"
557552
target="_blank"
@@ -576,7 +571,7 @@ exports[`Package Manager Page renders correctly 1`] = `
576571
</li>
577572
<li>
578573
<a
579-
aria-label="Node.js Slack Link"
574+
aria-label="Node.js Slack (opens in new tab)"
580575
href="https://slack.openjsf.org"
581576
rel="noopener noreferrer"
582577
target="_blank"

‎src/templates/__tests__/__snapshots__/learn.test.tsx.snap‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ exports[`Learn Template renders correctly 1`] = `
406406
>
407407
<li>
408408
<a
409-
aria-label="Node.js Slack Link"
409+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
410410
class="link"
411411
href="https://trademark-policy.openjsf.org/"
412412
rel="noopener noreferrer"
@@ -464,16 +464,11 @@ exports[`Learn Template renders correctly 1`] = `
464464
</li>
465465
<li>
466466
<a
467-
aria-label="Node.js Github Page Link"
467+
aria-label="Node.js Github Page (opens in new tab)"
468468
href="https://github.com/nodejs/node"
469469
rel="noopener noreferrer"
470470
target="_blank"
471471
>
472-
<span
473-
class="sr-only"
474-
>
475-
GitHub
476-
</span>
477472
<svg
478473
aria-hidden="true"
479474
class="svg-inline--fa fa-github "
@@ -494,7 +489,7 @@ exports[`Learn Template renders correctly 1`] = `
494489
</li>
495490
<li>
496491
<a
497-
aria-label="Node.js Twitter Link"
492+
aria-label="Node.js Twitter (opens in new tab)"
498493
href="https://twitter.com/nodejs"
499494
rel="noopener noreferrer"
500495
target="_blank"
@@ -519,7 +514,7 @@ exports[`Learn Template renders correctly 1`] = `
519514
</li>
520515
<li>
521516
<a
522-
aria-label="Node.js Slack Link"
517+
aria-label="Node.js Slack (opens in new tab)"
523518
href="https://slack.openjsf.org"
524519
rel="noopener noreferrer"
525520
target="_blank"

‎src/templates/__tests__/__snapshots__/post.test.tsx.snap‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ exports[`LearnLayout Template renders correctly 1`] = `
293293
>
294294
<li>
295295
<a
296-
aria-label="Node.js Slack Link"
296+
aria-label="Node.js Trademark Policy - PDF (Opens in new tab)"
297297
class="link"
298298
href="https://trademark-policy.openjsf.org/"
299299
rel="noopener noreferrer"
@@ -351,16 +351,11 @@ exports[`LearnLayout Template renders correctly 1`] = `
351351
</li>
352352
<li>
353353
<a
354-
aria-label="Node.js Github Page Link"
354+
aria-label="Node.js Github Page (opens in new tab)"
355355
href="https://github.com/nodejs/node"
356356
rel="noopener noreferrer"
357357
target="_blank"
358358
>
359-
<span
360-
class="sr-only"
361-
>
362-
GitHub
363-
</span>
364359
<svg
365360
aria-hidden="true"
366361
class="svg-inline--fa fa-github "
@@ -381,7 +376,7 @@ exports[`LearnLayout Template renders correctly 1`] = `
381376
</li>
382377
<li>
383378
<a
384-
aria-label="Node.js Twitter Link"
379+
aria-label="Node.js Twitter (opens in new tab)"
385380
href="https://twitter.com/nodejs"
386381
rel="noopener noreferrer"
387382
target="_blank"
@@ -406,7 +401,7 @@ exports[`LearnLayout Template renders correctly 1`] = `
406401
</li>
407402
<li>
408403
<a
409-
aria-label="Node.js Slack Link"
404+
aria-label="Node.js Slack (opens in new tab)"
410405
href="https://slack.openjsf.org"
411406
rel="noopener noreferrer"
412407
target="_blank"

0 commit comments

Comments
 (0)