deps: make V8 compilable with older glibc

targos · nodejs-github-bot · commit 307ccde5bff9 · 2022-04-18T06:02:56.000Z
Remove call to `memfd_create`. The function that references it is only used for V8 testing. PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
diff --git a/common.gypi b/common.gypi
@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.6',
+    'v8_embedder_string': '-node.7',
 
     ##### V8 defaults for Node.js #####
 
diff --git a/deps/v8/src/base/platform/platform-posix.cc b/deps/v8/src/base/platform/platform-posix.cc
@@ -581,25 +581,7 @@ void OS::FreeAddressSpaceReservation(AddressSpaceReservation reservation) {
 // Need to disable CFI_ICALL due to the indirect call to memfd_create.
 DISABLE_CFI_ICALL
 PlatformSharedMemoryHandle OS::CreateSharedMemoryHandleForTesting(size_t size) {
-#if V8_OS_LINUX && !V8_OS_ANDROID
-  // Use memfd_create if available, otherwise mkstemp.
-  using memfd_create_t = int (*)(const char*, unsigned int);
-  memfd_create_t memfd_create =
-      reinterpret_cast<memfd_create_t>(dlsym(RTLD_DEFAULT, "memfd_create"));
-  int fd = -1;
-  if (memfd_create) {
-    fd = memfd_create("V8MemFDForTesting", MFD_CLOEXEC);
-  } else {
-    char filename[] = "/tmp/v8_tmp_file_for_testing_XXXXXX";
-    fd = mkstemp(filename);
-    if (fd != -1) CHECK_EQ(0, unlink(filename));
-  }
-  if (fd == -1) return kInvalidSharedMemoryHandle;
-  CHECK_EQ(0, ftruncate(fd, size));
-  return SharedMemoryHandleFromFileDescriptor(fd);
-#else
   return kInvalidSharedMemoryHandle;
-#endif
 }
 
 // static
