Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

hasOwnProperty usage #1707

Description

@isaacs

These should use Object.prototype.hasOwnProperty.call instead of obj.hasOwnProperty.

lib/_debugger.js:    if (proto.hasOwnProperty(i) && ignored.indexOf(i) === -1) {
lib/module.js:  if (packageCache.hasOwnProperty(requestPath)) {
lib/querystring.js:    if (!obj.hasOwnProperty(k)) {
lib/repl.js:          if (!uniq.hasOwnProperty(c)) {

Causes server crashes when jerks request /foo?hasOwnProperty=x&y=z

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions