node-gyp includes $nodedir/common.gypi when creating build files for an add-on.
Per nodejs/CTC#62 (comment), that probably isn't future-proof and it's a bad idea in general: it makes add-ons pick up compiler and linker settings that aren't intended for them and may be actively harmful. People have filed bug reports about it.
Plan of action:
- Merge
common.gypi into addon.gypi.
- Strip everything that isn't needed by add-ons.
- Test the bejebus out of it with citgm.
node-gyp includes
$nodedir/common.gypiwhen creating build files for an add-on.Per nodejs/CTC#62 (comment), that probably isn't future-proof and it's a bad idea in general: it makes add-ons pick up compiler and linker settings that aren't intended for them and may be actively harmful. People have filed bug reports about it.
Plan of action:
common.gypiintoaddon.gypi.