chakrashim: remove supportsOverrideToString

Jianchun Xu · Jianchun Xu · commit 7f4cf1fb5859 · 2015-09-04T20:36:37.000-07:00
"supportsOverrideToString" was originally added to make old FastBuffer work. Buffer has long switched to TypedArray implementation. This is no longer used. Fix #80 Reviewed-by: @kunalspathak
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -1862,7 +1862,6 @@ class V8_EXPORT ObjectTemplate : public Template {
   V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(Local<Context> context);
 
   void SetClassName(Handle<String> name);
-  void SetSupportsOverrideToString();
 
   void SetAccessor(Handle<String> name,
                    AccessorGetterCallback getter,
diff --git a/deps/chakrashim/src/v8objecttemplate.cc b/deps/chakrashim/src/v8objecttemplate.cc
@@ -40,7 +40,6 @@ struct ObjectTemplateData : public TemplateData {
   IndexedPropertyEnumeratorCallback indexedPropertyEnumerator;
   Persistent<Value> indexedPropertyInterceptorData;
   int internalFieldCount;
-  bool supportsOverrideToString;
 
   ObjectTemplateData()
       : namedPropertyGetter(nullptr),
@@ -53,8 +52,7 @@ struct ObjectTemplateData : public TemplateData {
         indexedPropertyQuery(nullptr),
         indexedPropertyDeleter(nullptr),
         indexedPropertyEnumerator(nullptr),
-        internalFieldCount(0),
-        supportsOverrideToString(false) {
+        internalFieldCount(0) {
     HandleScope scope(nullptr);
     properties = Object::New();
   }
@@ -877,23 +875,6 @@ Local<Object> ObjectTemplate::NewInstance(Handle<Object> prototype) {
     if (error != JsNoError) {
       return Local<Object>();
     }
-
-    // this trick is needed in order to support the equals operator correctly:
-    if (objectTemplateData->supportsOverrideToString) {
-      JsValueRef proxyRef = newInstanceRef;
-
-      error = JsCreateObject(&newInstanceRef);
-
-      if (error != JsNoError) {
-        return Local<Object>();
-      }
-
-      error = JsSetPrototype(newInstanceRef, proxyRef);
-
-      if (error != JsNoError) {
-        return Local<Object>();
-      }
-    }
   }
 
   // clone the object template into the new instance
@@ -1092,15 +1073,4 @@ Handle<String> ObjectTemplate::GetClassName() {
   return objectTemplateData->className;
 }
 
-void ObjectTemplate::SetSupportsOverrideToString() {
-  void* externalData;
-  if (JsGetExternalData(this, &externalData) != JsNoError) {
-    return;
-  }
-
-  ObjectTemplateData *objectTemplateData =
-    reinterpret_cast<ObjectTemplateData*>(externalData);
-  objectTemplateData->supportsOverrideToString = true;
-}
-
 }  // namespace v8
