remove the type check in CreateDataView

bavulapati · bavulapati · commit 1770fbb7ebab · 2026-06-05T17:45:47.000+05:30
Signed-off-by: Balakrishna Avulapati &lt;ba@bavulapati.com&gt;
diff --git a/tests/js-native-api/test_dataview/CMakeLists.txt b/tests/js-native-api/test_dataview/CMakeLists.txt
@@ -1 +1 @@
-add_node_api_cts_experimental_addon(test_dataview test_dataview.c)
+add_node_api_cts_addon(test_dataview test_dataview.c)
diff --git a/tests/js-native-api/test_dataview/test.js b/tests/js-native-api/test_dataview/test.js
@@ -1,48 +1,46 @@
 "use strict";
 
-if (experimentalFeatures.sharedArrayBuffer) {
-  // Testing api calls for arrays
-  const test_dataview = loadAddon("test_dataview");
-
-  // Test for creating dataview with ArrayBuffer
-  {
-    const buffer = new ArrayBuffer(128);
-    const template = Reflect.construct(DataView, [buffer]);
-
-    const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
-    assert.ok(
-      theDataview instanceof DataView,
-      `Expect ${theDataview} to be a DataView`,
-    );
-  }
-
-  // Test for creating dataview with SharedArrayBuffer
-  {
-    const buffer = new SharedArrayBuffer(128);
-    const template = new DataView(buffer);
-
-    const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
-    assert.ok(
-      theDataview instanceof DataView,
-      `Expect ${theDataview} to be a DataView`,
-    );
-
-    assert.strictEqual(template.buffer, theDataview.buffer);
-  }
-
-  // Test for creating dataview with ArrayBuffer and invalid range
-  {
-    const buffer = new ArrayBuffer(128);
-    assert.throws(() => {
-      test_dataview.CreateDataView(buffer, 10, 200);
-    }, RangeError);
-  }
-
-  // Test for creating dataview with SharedArrayBuffer and invalid range
-  {
-    const buffer = new SharedArrayBuffer(128);
-    assert.throws(() => {
-      test_dataview.CreateDataView(buffer, 10, 200);
-    }, RangeError);
-  }
+// Testing api calls for dataview
+const test_dataview = loadAddon("test_dataview");
+
+// Test for creating dataview with ArrayBuffer
+{
+  const buffer = new ArrayBuffer(128);
+  const template = Reflect.construct(DataView, [buffer]);
+
+  const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
+  assert.ok(
+    theDataview instanceof DataView,
+    `Expect ${theDataview} to be a DataView`,
+  );
+}
+
+// Test for creating dataview with SharedArrayBuffer
+{
+  const buffer = new SharedArrayBuffer(128);
+  const template = new DataView(buffer);
+
+  const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
+  assert.ok(
+    theDataview instanceof DataView,
+    `Expect ${theDataview} to be a DataView`,
+  );
+
+  assert.strictEqual(template.buffer, theDataview.buffer);
+}
+
+// Test for creating dataview with ArrayBuffer and invalid range
+{
+  const buffer = new ArrayBuffer(128);
+  assert.throws(() => {
+    test_dataview.CreateDataView(buffer, 10, 200);
+  }, RangeError);
+}
+
+// Test for creating dataview with SharedArrayBuffer and invalid range
+{
+  const buffer = new SharedArrayBuffer(128);
+  assert.throws(() => {
+    test_dataview.CreateDataView(buffer, 10, 200);
+  }, RangeError);
 }
diff --git a/tests/js-native-api/test_dataview/test_dataview.c b/tests/js-native-api/test_dataview/test_dataview.c
@@ -18,21 +18,6 @@ static napi_value CreateDataView(napi_env env, napi_callback_info info) {
               "Wrong type of arguments. Expects a ArrayBuffer as the first "
               "argument.");
 
-  bool is_arraybuffer;
-  NODE_API_CALL(env, napi_is_arraybuffer(env, arraybuffer, &is_arraybuffer));
-
-  if (!is_arraybuffer) {
-    bool is_sharedarraybuffer;
-    NODE_API_CALL(
-        env,
-        node_api_is_sharedarraybuffer(env, arraybuffer, &is_sharedarraybuffer));
-    NODE_API_ASSERT(env,
-                    is_sharedarraybuffer,
-                    "Wrong type of arguments. Expects a SharedArrayBuffer or "
-                    "ArrayBuffer as the first "
-                    "argument.");
-  }
-
   napi_valuetype valuetype1;
   NODE_API_CALL(env, napi_typeof(env, args[1], &valuetype1));
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-add_node_api_cts_experimental_addon(test_dataview test_dataview.c)`
	`1`	`+add_node_api_cts_addon(test_dataview test_dataview.c)`