Add newlines to the ends of files and update README.md.

Gabriel Schulhof · Gabriel Schulhof · commit 24203c7975fd · 2018-10-01T17:56:27.000-04:00
diff --git a/1_hello_world/napi/hello.js b/1_hello_world/napi/hello.js
@@ -1,3 +1,3 @@
 var addon = require('bindings')('hello');
 
-console.log(addon.hello()); // 'world'
+console.log(addon.hello()); // 'world'
diff --git a/1_hello_world/node-addon-api/hello.js b/1_hello_world/node-addon-api/hello.js
@@ -1,3 +1,3 @@
 var addon = require('bindings')('hello');
 
-console.log(addon.hello()); // 'world'
+console.log(addon.hello()); // 'world'
diff --git a/2_function_arguments/node-addon-api/addon.js b/2_function_arguments/node-addon-api/addon.js
@@ -1,3 +1,3 @@
 var addon = require('bindings')('addon.node')
 
-console.log('This should be eight:', addon.add(3, 5))
+console.log('This should be eight:', addon.add(3, 5))
diff --git a/3_callbacks/node-addon-api/addon.js b/3_callbacks/node-addon-api/addon.js
@@ -2,4 +2,4 @@ var addon = require('bindings')('addon');
 
 addon(function(msg){
   console.log(msg); // 'hello world'
-});
+});
diff --git a/4_object_factory/napi/addon.js b/4_object_factory/napi/addon.js
@@ -2,4 +2,4 @@ var addon = require('bindings')('addon');
 
 var obj1 = addon('hello');
 var obj2 = addon('world');
-console.log(obj1.msg+' '+obj2.msg); // 'hello world'
+console.log(obj1.msg+' '+obj2.msg); // 'hello world'
diff --git a/5_function_factory/node-addon-api/addon.js b/5_function_factory/node-addon-api/addon.js
@@ -1,4 +1,4 @@
 var addon = require('bindings')('addon');
 
 var fn = addon();
-console.log(fn()); // 'hello world'
+console.log(fn()); // 'hello world'
diff --git a/README.md b/README.md
@@ -1,21 +1,34 @@
-Node.js Addon Examples - ABI Stable PoC
+Node.js Addon Examples
 =========================================
 
-This repository is the home of the Addon Examples as extended
-for the proof of concept work being done to develop an ABI
-stable API for use my node modules.
+This repository is the home of the Addon Examples.
 
-For more details please read the node-eps covering this effort.
-The current PR for the eps is: https://github.com/nodejs/node-eps/pull/20
+The directory structure is as follows:
 
-```text
-$ sudo npm install node-gyp -g
 ```
+<name of example>
+  |
+  +--- <implementation 1>
+  |      |
+  |      +--- files...
+  +--- <implementation 2>
+  .      |
+  .      +--- files...
+  .
+```
+
+Implementations are named either after Node.js versions (`node_0.10`,
+`node_0.12`, etc), or Node.js addon implementation APIs (`nan`, `napi`,
+or `node-addon-api`).
 
-In each example directory, run:
+Implementations against unsupported versions of Node.js are provided for
+completess and historical context. They are not maintained.
+
+In each example's implementation subdirectory, run
 
 ```text
 $ npm install
-$ node-gyp rebuild
 $ node ./
 ```
+
+to see the example in action.
diff --git a/async_pi_estimate/nan/addon.js b/async_pi_estimate/nan/addon.js
@@ -41,4 +41,4 @@ function runAsync() {
 }
 
 runSync();
-runAsync();
+runAsync();
diff --git a/async_pi_estimate/node-addon-api/addon.cc b/async_pi_estimate/node-addon-api/addon.cc
@@ -10,4 +10,4 @@ Napi::Object Init(Napi::Env env, Napi::Object exports) {
   return exports;
 }
 
-NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)
+NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)
diff --git a/async_pi_estimate/node-addon-api/async.cc b/async_pi_estimate/node-addon-api/async.cc
@@ -36,4 +36,4 @@ Napi::Value CalculateAsync(const Napi::CallbackInfo& info) {
   PiWorker* piWorker = new PiWorker(callback, points);
   piWorker->Queue();
   return info.Env().Undefined();
-}
+}
diff --git a/async_pi_estimate/node-addon-api/pi_est.cc b/async_pi_estimate/node-addon-api/pi_est.cc
@@ -52,4 +52,4 @@ double Estimate (int points) {
 
   // calculate ratio and multiply by 4 for π
   return (inside / static_cast<double>(points)) * 4;
-}
+}
diff --git a/emit_event_from_cpp/node-addon-api/binding.gyp b/emit_event_from_cpp/node-addon-api/binding.gyp
@@ -27,4 +27,4 @@
       ]
     }
   ]
-}
+}
diff --git a/emit_event_from_cpp/node-addon-api/index.js b/emit_event_from_cpp/node-addon-api/index.js
@@ -16,4 +16,4 @@ emitter.on('end', () => {
     console.log('### END ###')
 })
 
-addon.callEmit(emitter.emit.bind(emitter))
+addon.callEmit(emitter.emit.bind(emitter))
diff --git a/emit_event_from_cpp/node-addon-api/src/emit-from-cpp.cc b/emit_event_from_cpp/node-addon-api/src/emit-from-cpp.cc
@@ -24,4 +24,4 @@ Napi::Object Init(Napi::Env env, Napi::Object exports) {
     return exports;
 }
 
-NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init);
+NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init);
diff --git a/inherits_from_event_emitter/node-addon-api/index.js b/inherits_from_event_emitter/node-addon-api/index.js
@@ -20,4 +20,4 @@ emitter.on('end', () => {
     console.log('### END ###')
 })
 
-emitter.callAndEmit()
+emitter.callAndEmit()
diff --git a/inherits_from_event_emitter/node-addon-api/src/binding.cc b/inherits_from_event_emitter/node-addon-api/src/binding.cc
@@ -6,4 +6,4 @@ Napi::Object Init(Napi::Env env, Napi::Object exports) {
     return exports;
 }
 
-NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)
+NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)
diff --git a/inherits_from_event_emitter/node-addon-api/src/native-emitter.cc b/inherits_from_event_emitter/node-addon-api/src/native-emitter.cc
@@ -37,4 +37,4 @@ Napi::Value NativeEmitter::CallAndEmit(const Napi::CallbackInfo& info) {
     }
     emit.Call(info.This(), { Napi::String::New(env, "end") });
     return Napi::String::New(env, "OK");
-}
+}
diff --git a/inherits_from_event_emitter/node-addon-api/src/native-emitter.h b/inherits_from_event_emitter/node-addon-api/src/native-emitter.h
@@ -9,4 +9,4 @@ class NativeEmitter : public Napi::ObjectWrap<NativeEmitter> {
         static Napi::FunctionReference constructor;
 
         Napi::Value CallAndEmit(const Napi::CallbackInfo& info);
-};
+};

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`var addon = require('bindings')('hello');`
`2`	`2`
`3`		`-console.log(addon.hello()); // 'world'`
	`3`	`+console.log(addon.hello()); // 'world'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`var addon = require('bindings')('addon.node')`
`2`	`2`
`3`		`-console.log('This should be eight:', addon.add(3, 5))`
	`3`	`+console.log('This should be eight:', addon.add(3, 5))`
Original file line number	Diff line number	Diff line change
`@@ -41,4 +41,4 @@ function runAsync() {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`runSync();`
`44`		`-runAsync();`
	`44`	`+runAsync();`
Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,4 @@ Napi::Object Init(Napi::Env env, Napi::Object exports) {`
`10`	`10`	`return exports;`
`11`	`11`	`}`
`12`	`12`
`13`		`-NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)`
	`13`	`+NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)`