fs: add built-in fs.operation diagnostics channels - #65370
Draft
mcollina wants to merge 1 commit into
Draft
Conversation
Add a built-in node:diagnostics_channel channel family for file system operations performed through node:fs and node:fs/promises. The channels are named tracing:fs.operation:start, :end, :asyncStart, :asyncEnd, and :error, and share an event payload carrying the operation name, the API (sync/callback/promise), path/dest/fd fields when applicable, plus result/error following TracingChannel conventions. Events are published from the internal shared file system layer rather than the JS wrappers, so captured function references still emit events. Signed-off-by: Matteo Collina <hello@matteocollina.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a built-in
node:diagnostics_channelchannel family for file system operations performed throughnode:fsandnode:fs/promises, addressing #65330.The channels are
tracing:fs.operation:start,:end,:asyncStart,:asyncEnd, and:error, and share an event payload carrying the operation name, the API (sync/callback/promise),path/dest/fdfields when applicable, plusresult/errorfollowing TracingChannel conventions. Subscribers can usediagnostics_channel.tracingChannel('fs.operation')to subscribe to all events at once.Events are published from the internal shared file system layer rather than the JS wrappers, so captured function references still emit events. Adds documentation and a new
test/parallel/test-diagnostics-channel-fs.js.