ffi: reject direct SharedArrayBuffer pointers - #65233
Draft
trivikr wants to merge 1 commit into
Draft
Conversation
Reject direct SharedArrayBuffer pointer arguments in the JavaScript wrapper and native fast-buffer helper. This keeps validation behavior consistent before and after optimization. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
Collaborator
|
Review requested:
|
ShogunPanda
approved these changes
Aug 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65233 +/- ##
==========================================
- Coverage 90.32% 90.31% -0.01%
==========================================
Files 760 760
Lines 248629 248629
Branches 46936 46933 -3
==========================================
- Hits 224578 224561 -17
+ Misses 15475 15471 -4
- Partials 8576 8597 +21
🚀 New features to boost your workflow:
|
Collaborator
trivikr
marked this pull request as draft
August 12, 2026 17:19
Member
Author
|
Converted to draft since not ok 3 ffi/test-ffi-fast-buffer
---
duration_ms: 745.01400
severity: crashed
exitcode: -5
stack: |-
(node:39387614) internal/test/binding: These APIs are for internal testing only. Do not use them.
(Use `node --trace-warnings ...` to show where the warning was created)
(node:39387614) ExperimentalWarning: FFI is an experimental feature and might change at any time
#
# Fatal error in , line 0
# Check failed: EnsureCompiledAndFeedbackVector(isolate, function, &is_compiled_scope).
#
#
#
#FailureMessage Object: fffffffffffc608
----- Native stack trace -----
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65232
Reject direct SharedArrayBuffer pointer arguments in the JavaScript wrapper and native fast-buffer helper. This keeps validation behavior consistent before and after optimization.
Assisted-by: codex:gpt-5.6-sol