stream: reject strings in ReadableStream.from#64465
Draft
trivikr wants to merge 1 commit into
Draft
Conversation
Use Web IDL async_sequence semantics for ReadableStream.from(), which require the input to be an object. This causes primitive strings to throw a TypeError instead of being iterated by code point. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
Collaborator
|
Review requested:
|
Member
|
I'd rather go a different way with this... while it is not strictly spec compliant, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #64288
Depends on: web-platform-tests/wpt#59594
Use Web IDL
async_sequence<any>semantics forReadableStream.from().This changes
ReadableStream.from('abc')to throw aTypeErrorinsteadof iterating over the string's Unicode code points. Web IDL async
sequences require the input value to be an ECMAScript object.
The corresponding WPT change is included provisionally. This PR should
not land until the upstream WPT PR is merged. Afterward, the Streams WPT
fixtures will be regenerated with
git node wpt streams.Assisted-by: openai:gpt-5.6-sol