From b7821308d8508e5e7984984c0781dd54c6c9d626 Mon Sep 17 00:00:00 2001
From: Yagiz Nizipli <yagiz@nizipli.com>
Date: Thu, 18 Jun 2026 13:33:13 -0400
Subject: [PATCH] src: add --enable-run-hooks for node --run pre scripts

node --run intentionally does not run lifecycle scripts. Add an opt-in
--enable-run-hooks flag that, together with --run, also runs the
matching "pre<script>" hook (when present in the package.json
"scripts" object) before the requested script.

The hook is run first via a ProcessRunner; if it exits with a non-zero
status the run is aborted and the main script is not executed. Mirroring
npm, positional arguments after `--` are forwarded to the requested
script only, not to the hook. Missing hooks, non-string hook values, and
a missing main script are all handled without running anything spurious.
Without the flag, --run never runs hooks, so existing behavior is
unchanged.

Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
---
 doc/api/cli.md                              |  18 +++-
 doc/node.1                                  |   6 ++
 src/node.cc                                 |   6 +-
 src/node_options.cc                         |   4 +
 src/node_options.h                          |   1 +
 src/node_task_runner.cc                     |  31 +++++-
 src/node_task_runner.h                      |   3 +-
 test/fixtures/run-script/hooks/package.json |  17 ++++
 test/parallel/test-node-run-hooks.js        | 102 ++++++++++++++++++++
 9 files changed, 183 insertions(+), 5 deletions(-)
 create mode 100644 test/fixtures/run-script/hooks/package.json
 create mode 100644 test/parallel/test-node-run-hooks.js

diff --git a/doc/api/cli.md b/doc/api/cli.md
index 79f02ee5eddd86..007cdee54d9a0f 100644
--- a/doc/api/cli.md
+++ b/doc/api/cli.md
@@ -861,6 +861,19 @@ added: v6.0.0
 Enable FIPS-compliant crypto at startup. (Requires Node.js to be built
 against FIPS-compatible OpenSSL.)
 
+### `--enable-run-hooks`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+When used together with [`--run`][], also run the matching `"pre<script>"`
+lifecycle hook (if one exists in the `"scripts"` object) before the requested
+script. For example, `node --run build --enable-run-hooks` runs `prebuild`
+first, and only runs `build` if `prebuild` exits successfully. Positional
+arguments passed after `--` are forwarded to the requested script only, not to
+the hook. Without this flag, `--run` never runs lifecycle hooks.
+
 ### `--enable-source-maps`
 
 <!-- YAML
@@ -2683,7 +2696,8 @@ cases.
 Some features of other `run` implementations that are intentionally excluded
 are:
 
-* Running `pre` or `post` scripts in addition to the specified script.
+* Running `post` scripts in addition to the specified script. Running the
+  matching `pre` script is available as an opt-in via [`--enable-run-hooks`][].
 * Defining package manager-specific environment variables.
 
 #### Environment variables
@@ -4429,6 +4443,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
 [`--cpu-prof-dir`]: #--cpu-prof-dir
 [`--diagnostic-dir`]: #--diagnostic-dirdirectory
 [`--disable-sigusr1`]: #--disable-sigusr1
+[`--enable-run-hooks`]: #--enable-run-hooks
 [`--env-file-if-exists`]: #--env-file-if-existsfile
 [`--env-file`]: #--env-filefile
 [`--experimental-sea-config`]: single-executable-applications.md#1-generating-single-executable-preparation-blobs
@@ -4441,6 +4456,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
 [`--print`]: #-p---print-script
 [`--redirect-warnings`]: #--redirect-warningsfile
 [`--require`]: #-r---require-module
+[`--run`]: #--run
 [`--use-env-proxy`]: #--use-env-proxy
 [`--use-system-ca`]: #--use-system-ca
 [`AsyncLocalStorage`]: async_context.md#class-asynclocalstorage
diff --git a/doc/node.1 b/doc/node.1
index dc42c5287026a7..ef9a82b25a30b1 100644
--- a/doc/node.1
+++ b/doc/node.1
@@ -533,6 +533,12 @@ priority than \fB--dns-result-order\fR.
 Enable FIPS-compliant crypto at startup. (Requires Node.js to be built
 against FIPS-compatible OpenSSL.)
 .
+.It Fl -enable-run-hooks
+When used together with \fB--run\fR, also run the matching \fB"pre<script>"\fR
+lifecycle hook (if one exists in the \fB"scripts"\fR object) before the
+requested script. The hook must exit successfully for the script to run, and
+positional arguments are forwarded to the requested script only, not the hook.
+.
 .It Fl -enable-source-maps
 Enable Source Map support for stack traces.
 When using a transpiler, such as TypeScript, stack traces thrown by an
diff --git a/src/node.cc b/src/node.cc
index 4ba019ddca05f4..2f781d5de6b664 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -1131,8 +1131,10 @@ InitializeOncePerProcessInternal(const std::vector<std::string>& args,
   if (!per_process::cli_options->run.empty()) {
     auto positional_args = task_runner::GetPositionalArgs(args);
     result->early_return_ = true;
-    task_runner::RunTask(
-        result, per_process::cli_options->run, positional_args);
+    task_runner::RunTask(result,
+                         per_process::cli_options->run,
+                         positional_args,
+                         per_process::cli_options->enable_run_hooks);
     return result;
   }
 
diff --git a/src/node_options.cc b/src/node_options.cc
index 7f036cd04163de..e1ac7c8d7ed14e 100644
--- a/src/node_options.cc
+++ b/src/node_options.cc
@@ -1530,6 +1530,10 @@ PerProcessOptionsParser::PerProcessOptionsParser(
   AddOption("--run",
             "Run a script specified in package.json",
             &PerProcessOptions::run);
+  AddOption("--enable-run-hooks",
+            "When used with --run, also run the matching \"pre<script>\" "
+            "lifecycle hook (if any) before the script",
+            &PerProcessOptions::enable_run_hooks);
   AddOption(
       "--disable-wasm-trap-handler",
       "Disable trap-handler-based WebAssembly bound checks. V8 will insert "
diff --git a/src/node_options.h b/src/node_options.h
index f7a8a999d85a1b..ce02ca142f0a16 100644
--- a/src/node_options.h
+++ b/src/node_options.h
@@ -351,6 +351,7 @@ class PerProcessOptions : public Options {
   bool print_version = false;
   std::string experimental_sea_config;
   std::string run;
+  bool enable_run_hooks = false;
 
   std::string build_sea;
 #ifdef NODE_HAVE_I18N_SUPPORT
diff --git a/src/node_task_runner.cc b/src/node_task_runner.cc
index 3e15a70e72660c..7031318aa059df 100644
--- a/src/node_task_runner.cc
+++ b/src/node_task_runner.cc
@@ -251,7 +251,8 @@ FindPackageJson(const std::filesystem::path& cwd) {
 
 void RunTask(const std::shared_ptr<InitializationResultImpl>& result,
              std::string_view command_id,
-             const std::vector<std::string_view>& positional_args) {
+             const std::vector<std::string_view>& positional_args,
+             bool run_hooks) {
   auto cwd = std::filesystem::current_path();
   auto package_json = FindPackageJson(cwd);
 
@@ -300,6 +301,21 @@ void RunTask(const std::shared_ptr<InitializationResultImpl>& result,
     return;
   }
 
+  // When lifecycle hooks are enabled, resolve the matching "pre<script>" hook
+  // up front. We copy the command into an owned string and rewind the scripts
+  // object so the main script lookup below is unaffected. A missing hook, or a
+  // hook whose value is not a string, is simply ignored.
+  std::string pre_command;
+  std::string pre_script_name;
+  if (run_hooks) {
+    pre_script_name = "pre" + std::string(command_id);
+    std::string_view pre_view;
+    if (!scripts_object[pre_script_name].get_string().get(pre_view)) {
+      pre_command = std::string(pre_view);
+    }
+    scripts_object.reset();
+  }
+
   // If the command_id is not found in the scripts object, throw an error.
   std::string_view command;
   if (auto command_error =
@@ -339,6 +355,19 @@ void RunTask(const std::shared_ptr<InitializationResultImpl>& result,
     return;
   }
 
+  // Run the "pre<script>" lifecycle hook first when enabled and present.
+  // Mirroring npm, lifecycle hooks do not receive the positional arguments
+  // (those belong to the main script only), and a failing hook aborts the run
+  // before the main script is executed.
+  if (run_hooks && !pre_command.empty()) {
+    auto pre_runner = ProcessRunner(
+        result, path, pre_script_name, pre_command, path_env_var, {});
+    pre_runner.Run();
+    if (result->exit_code_ != ExitCode::kNoFailure) {
+      return;
+    }
+  }
+
   auto runner = ProcessRunner(
       result, path, command_id, command, path_env_var, positional_args);
   runner.Run();
diff --git a/src/node_task_runner.h b/src/node_task_runner.h
index 15573498f7393a..aa2514add2b3f2 100644
--- a/src/node_task_runner.h
+++ b/src/node_task_runner.h
@@ -81,7 +81,8 @@ FindPackageJson(const std::filesystem::path& cwd);
 
 void RunTask(const std::shared_ptr<InitializationResultImpl>& result,
              std::string_view command_id,
-             const PositionalArgs& positional_args);
+             const PositionalArgs& positional_args,
+             bool run_hooks = false);
 PositionalArgs GetPositionalArgs(const std::vector<std::string>& args);
 std::string EscapeShell(std::string_view command);
 
diff --git a/test/fixtures/run-script/hooks/package.json b/test/fixtures/run-script/hooks/package.json
new file mode 100644
index 00000000000000..126a4dd051e094
--- /dev/null
+++ b/test/fixtures/run-script/hooks/package.json
@@ -0,0 +1,17 @@
+{
+  "scripts": {
+    "prebuild": "echo prebuild-output",
+    "build": "echo build-output",
+
+    "prefail-build": "echo prefail-output && exit 1",
+    "fail-build": "echo fail-build-main-output",
+
+    "prewith-args": "echo prehook-no-args",
+    "with-args": "echo main-output",
+
+    "no-hook": "echo no-hook-main-output",
+
+    "prebad-type": 123,
+    "bad-type": "echo bad-type-main-output"
+  }
+}
diff --git a/test/parallel/test-node-run-hooks.js b/test/parallel/test-node-run-hooks.js
new file mode 100644
index 00000000000000..8160f17537ae27
--- /dev/null
+++ b/test/parallel/test-node-run-hooks.js
@@ -0,0 +1,102 @@
+'use strict';
+
+const common = require('../common');
+common.requireNoPackageJSONAbove();
+
+const { it, describe } = require('node:test');
+const assert = require('node:assert');
+
+const fixtures = require('../common/fixtures');
+const hooksDir = fixtures.path('run-script/hooks');
+
+describe('node --run [command] with lifecycle hooks', () => {
+  it('runs the "pre<script>" hook before the script with --enable-run-hooks', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'build', '--enable-run-hooks'],
+      { cwd: hooksDir },
+    );
+    assert.strictEqual(child.code, 0);
+    assert.strictEqual(child.stderr, '');
+    assert.match(child.stdout, /prebuild-output/);
+    assert.match(child.stdout, /build-output/);
+    // The hook must run strictly before the main script.
+    assert.ok(
+      child.stdout.indexOf('prebuild-output') <
+        child.stdout.indexOf('build-output'),
+      `expected prebuild-output before build-output, got: ${child.stdout}`,
+    );
+  });
+
+  it('does not run the "pre<script>" hook without the flag', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'build'],
+      { cwd: hooksDir },
+    );
+    assert.strictEqual(child.code, 0);
+    assert.strictEqual(child.stderr, '');
+    assert.match(child.stdout, /build-output/);
+    assert.doesNotMatch(child.stdout, /prebuild-output/);
+  });
+
+  it('aborts and does not run the script when the hook fails', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'fail-build', '--enable-run-hooks'],
+      { cwd: hooksDir },
+    );
+    // The failing hook exits with status 1 and the main script never runs.
+    assert.strictEqual(child.code, 1);
+    assert.match(child.stdout, /prefail-output/);
+    assert.doesNotMatch(child.stdout, /fail-build-main-output/);
+  });
+
+  it('runs the failing script normally when hooks are disabled', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'fail-build'],
+      { cwd: hooksDir },
+    );
+    // Without the flag the "prefail-build" hook is ignored entirely.
+    assert.strictEqual(child.code, 0);
+    assert.match(child.stdout, /fail-build-main-output/);
+    assert.doesNotMatch(child.stdout, /prefail-output/);
+  });
+
+  it('passes positional arguments to the script only, not the hook', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'with-args', '--enable-run-hooks', '--', 'EXTRA1', 'EXTRA2'],
+      { cwd: hooksDir },
+    );
+    assert.strictEqual(child.code, 0);
+    assert.strictEqual(child.stderr, '');
+    assert.match(child.stdout, /prehook-no-args/);
+    assert.match(child.stdout, /main-output EXTRA1 EXTRA2/);
+    // The hook must not receive the positional arguments.
+    assert.doesNotMatch(child.stdout, /prehook-no-args EXTRA1/);
+  });
+
+  it('runs the script when there is no matching hook', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'no-hook', '--enable-run-hooks'],
+      { cwd: hooksDir },
+    );
+    assert.strictEqual(child.code, 0);
+    assert.strictEqual(child.stderr, '');
+    assert.match(child.stdout, /no-hook-main-output/);
+  });
+
+  it('ignores a hook whose value is not a string', async () => {
+    const child = await common.spawnPromisified(
+      process.execPath,
+      ['--run', 'bad-type', '--enable-run-hooks'],
+      { cwd: hooksDir },
+    );
+    assert.strictEqual(child.code, 0);
+    assert.strictEqual(child.stderr, '');
+    assert.match(child.stdout, /bad-type-main-output/);
+  });
+});