deps: add ngtcp2_fmt.c to build configuration (ngtcp2.gyp)#63821
Open
ShenHongFei wants to merge 1 commit into
Open
deps: add ngtcp2_fmt.c to build configuration (ngtcp2.gyp)#63821ShenHongFei wants to merge 1 commit into
ShenHongFei wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Contributor
Author
|
This PR has added this file. 
|
pimterry
approved these changes
Jun 9, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following compilation configuration will result in an error.
After investigation, it was found that the sources section of the ngtcp2.gyp configuration file was missing the ngtcp2_fmt.c file, which caused the linking failure. After adding it, local compilation could be done normally.