Skip to content

tools: update the llhttp updater script #63819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −40
Open

tools: update the llhttp updater script #63819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a7d771
tools: update the llhttp updater script
aduh95 Jun 9, 2026
ba33c62
fixup! tools: update the llhttp updater script
aduh95 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 18 additions & 40 deletions tools/dep_updaters/update-llhttp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh
set -e
set -ex

# Shell script to update llhttp in the source tree to specific version

Expand All @@ -8,12 +8,14 @@ DEPS_DIR="${BASE_DIR}/deps"

[ -z "$NODE" ] && NODE="$BASE_DIR/out/Release/node"
[ -x "$NODE" ] || NODE=$(command -v node)
NPM_DIR="$DEPS_DIR/npm/bin"
NPM="$NPM_DIR/npm-cli.js"

# shellcheck disable=SC1091
. "$BASE_DIR/tools/dep_updaters/utils.sh"

if [ -n "$LOCAL_COPY" ]; then
NEW_VERSION=$(node -e "console.log(JSON.parse(require('fs').readFileSync('$LOCAL_COPY/package.json', 'utf-8')).version)")
NEW_VERSION=$(PACKAGE_JSON="$LOCAL_COPY/package.json" node -p "require(process.env.PACKAGE_JSON).version")
else
NEW_VERSION="$("$NODE" --input-type=module <<'EOF'
const res = await fetch('https://api.github.com/repos/nodejs/llhttp/releases/latest',
Expand Down Expand Up @@ -47,51 +49,27 @@ echo "Making temporary workspace ..."
WORKSPACE=$(mktemp -d 2> /dev/null || mktemp -d -t 'tmp')
trap cleanup INT TERM EXIT

cd "$WORKSPACE"
if [ -z "$LOCAL_COPY" ]; then
echo "Downloading llhttp source..."
curl -fsSL "https://github.com/nodejs/llhttp/archive/refs/tags/v$NEW_VERSION.tar.gz" | tar xz -C "$WORKSPACE"

LOCAL_COPY="$(find "$WORKSPACE" -mindepth 1 -maxdepth 1 -type d -print -quit)"
fi

echo "Replacing existing llhttp (except GYP and GN build files)"
mv "$DEPS_DIR/llhttp/"*.gn "$DEPS_DIR/llhttp/"*.gni "$WORKSPACE/"

if [ -n "$LOCAL_COPY" ]; then
echo "Copying llhttp release from $LOCAL_COPY ..."

echo "Building llhttp ..."
cd "$BASE_DIR"
echo "Building llhttp ..."
(
cd "$LOCAL_COPY"
npm install
"$NODE" "$NPM" ci --ignore-scripts
"$NODE" "$NPM" exec tsc
RELEASE=$NEW_VERSION make release
)

echo "Copying llhttp release ..."
rm -rf "$DEPS_DIR/llhttp"
cp -a release "$DEPS_DIR/llhttp"
elif echo "$NEW_VERSION" | grep -qs "/" ; then # Download a release
REPO="git@github.com:$NEW_VERSION.git"
BRANCH=$2
[ -z "$BRANCH" ] && BRANCH=main

echo "Cloning llhttp source archive $REPO ..."
git clone "$REPO" llhttp
cd llhttp
echo "Checking out branch $BRANCH ..."
git checkout "$BRANCH"

echo "Building llhttp ..."
npm install
RELEASE=$NEW_VERSION make release

echo "Copying llhttp release ..."
rm -rf "$DEPS_DIR/llhttp"
cp -a release "$DEPS_DIR/llhttp"
else
echo "Download llhttp release $NEW_VERSION ..."
LLHTTP_TARBALL="llhttp-v$NEW_VERSION.tar.gz"
curl -sL -o "$LLHTTP_TARBALL" "https://github.com/nodejs/llhttp/archive/refs/tags/release/v$NEW_VERSION.tar.gz"
gzip -dc "$LLHTTP_TARBALL" | tar xf -

echo "Copying llhttp release ..."
rm -rf "$DEPS_DIR/llhttp"
cp -a "llhttp-release-v$NEW_VERSION" "$DEPS_DIR/llhttp"
fi
echo "Overwriting vendored files..."
rm -rf "$DEPS_DIR/llhttp"
cp -a "$LOCAL_COPY/release" "$DEPS_DIR/llhttp"

mv "$WORKSPACE/"*.gn "$WORKSPACE/"*.gni "$DEPS_DIR/llhttp"

Expand Down