tools: enforce iterator result property order#63526
Open
trivikr wants to merge 1 commit into
Open
Conversation
Add a custom ESLint rule requiring iterator result objects to place `done` before `value`, and update existing lib iterator result objects to follow the rule. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63526 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 730 730
Lines 234205 234205
Branches 43927 43931 +4
=======================================
+ Hits 211559 211560 +1
+ Misses 14370 14366 -4
- Partials 8276 8279 +3
🚀 New features to boost your workflow:
|
MattiasBuelens
approved these changes
May 24, 2026
Collaborator
jasnell
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a custom ESLint rule to enforce
donebeforevaluein iterator result objects.This keeps iterator result object literals consistent across
lib/, and includes a fixerthat swaps the properties when they are in the wrong order.
The existing iterator result object literals in
lib/have been updated to match the new rule.Refs: #63521 (comment)
Assisted-by: openai:gpt-5.5