From 7a458f9b8287e01fc3d35750f25f7d164383f737 Mon Sep 17 00:00:00 2001 From: atlowChemi Date: Wed, 20 May 2026 10:23:20 +0300 Subject: [PATCH] test: isolate rerun-failures state file under tmpdir The rerun-failures state file lived at a fixed path under fixtures/, so concurrent invocations of test-runner-test-rerun-failures (e.g. `python tools/test.py --repeat 100 -j 16 ...`) raced on a single file and failed intermittently. Move the path to `tmpdir.resolve(...)` so each process gets its own scratch state. Signed-off-by: atlowChemi --- test/parallel/test-runner-test-rerun-failures.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-runner-test-rerun-failures.js b/test/parallel/test-runner-test-rerun-failures.js index 585d5f25f04a59..6d351481b8b5bf 100644 --- a/test/parallel/test-runner-test-rerun-failures.js +++ b/test/parallel/test-runner-test-rerun-failures.js @@ -1,5 +1,6 @@ 'use strict'; const common = require('../common'); +const tmpdir = require('../common/tmpdir'); const fixtures = require('../common/fixtures'); const assert = require('node:assert'); @@ -8,7 +9,8 @@ const { setTimeout } = require('node:timers/promises'); const { test, beforeEach, afterEach, run } = require('node:test'); const fixture = fixtures.path('test-runner', 'rerun.js'); -const stateFile = fixtures.path('test-runner', 'rerun-state.json'); +tmpdir.refresh(); +const stateFile = tmpdir.resolve('rerun-state.json'); beforeEach(() => rm(stateFile, { force: true })); afterEach(() => rm(stateFile, { force: true }));