Skip to content

Exposing more isXyz helpers through node_util.cc. #7196

Closed
Closed
Exposing more isXyz helpers through node_util.cc.#7196
Labels
c++Issues and PRs that require attention from people who are familiar with C++.utilIssues and PRs related to the built-in util module.
@jdalton

Description

@jdalton
jdalton
opened on Jun 7, 2016

I noticed that node/src/node_util.cc has

#define VALUE_METHOD_MAP(V)                                                   \
  V(isArrayBuffer, IsArrayBuffer)                                             \
  V(isDataView, IsDataView)                                                   \
  V(isDate, IsDate)                                                           \
  V(isMap, IsMap)                                                             \
  V(isMapIterator, IsMapIterator)                                             \
  V(isPromise, IsPromise)                                                     \
  V(isRegExp, IsRegExp)                                                       \
  V(isSet, IsSet)                                                             \
  V(isSetIterator, IsSetIterator)                                             \
  V(isTypedArray, IsTypedArray)

Which is great!

Is there interest in filling it out with IsWeakMap, IsWeakSet, IsProxy, IsSharedArrayBuffer,
or others?

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.utilIssues and PRs related to the built-in util module.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions