You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
tls: TLSSocket session deserialization failure leaves errors on the OpenSSL error queue (wrong error codes in later crypto calls) #67204
What is the expected behavior? The same error code before and after. A session that cannot be deserialized should not leave errors on the OpenSSL error queue.
What do you see instead?after: ERR_OSSL_ASN1_TOO_LONG. The leftover error from d2i_SSL_SESSION is reported by an unrelated call.
TLSWrap::SetSession → GetTLSSession → d2i_SSL_SESSION does not clear or pop the error queue on failure (// TODO(tniessen): figure out error handling). Using ClearErrorOnReturn there, or throwing ERR_TLS_INVALID_SESSION, would avoid it.
Activity