test-timers-reliability.js is failing consistently on OS X (and probably elsewhere). Is this something that needs to be addressed or is the test obsolete?
CC=@Fishrock123
It isn't caught on CI because this particular test is not run on CI. I don't know why it was excluded. Might have been placed in a directory that was appropriate for an older version of Node.js and never moved to test/parallel or test/sequential.
Here is the output I get on OS X:
/Applications/Xcode.app/Contents/Developer/usr/bin/make --directory=tools faketime
cd /Users/trott/io.js/tools/faketime && \
git checkout master && \
PREFIX=/Users/trott/io.js/tools/faketime/src make
Already on 'master'
Your branch is up-to-date with 'origin/master'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.OSX -C src all
make[3]: Nothing to be done for `all'.
/usr/bin/python tools/test.py --mode=release timers
=== release test-timers-reliability ===
Path: timers/test-timers-reliability
Assertion failed: (cb_v->IsFunction()), function MakeCallback, file ../src/async-wrap-inl.h, line 107.
Caught Abort trap: 6
Command: tools/faketime/src/faketime --exclude-monotonic -f "2014-07-21 09:00:00" out/Release/node /Users/trott/io.js/test/timers/test-timers-reliability.js
[00:07|% 100|+ 0|- 1]: Done
make: *** [test-timers] Error 1
test-timers-reliability.jsis failing consistently on OS X (and probably elsewhere). Is this something that needs to be addressed or is the test obsolete?CC=@Fishrock123
It isn't caught on CI because this particular test is not run on CI. I don't know why it was excluded. Might have been placed in a directory that was appropriate for an older version of Node.js and never moved to
test/parallelortest/sequential.Here is the output I get on OS X: