-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
N-API reference management leaks memory #34731
Copy link
Copy link
Closed
Labels
flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.memoryIssues and PRs related to the memory management or memory footprint.Issues and PRs related to the memory management or memory footprint.node-apiIssues and PRs related to the Node-API.Issues and PRs related to the Node-API.
Description
Metadata
Metadata
Assignees
Labels
flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.memoryIssues and PRs related to the memory management or memory footprint.Issues and PRs related to the memory management or memory footprint.node-apiIssues and PRs related to the Node-API.Issues and PRs related to the Node-API.
After making the
node-api/test_worker_terminate_finalizationcomplete run as expected in #34726, it starts failing under ASAN/valgrind because it leaks memory (the reference fromnapi_create_reference()in the test is never freed).I’ve tried to debug this for an hour, but got nowhere, so I’ll open a PR to just skip the test (shouldn’t exactly make things worse since the test hasn’t been working until today anyway).
/cc The only people who understand N-API reference lifetime management, aka @gabrielschulhof and maybe @mhdawson