Some `http2` errors are not captured

* **Version**: v12.6.0
* **Platform**: Linux solus 5.1.14-121.current #1 SMP PREEMPT Sun Jun 23 13:57:07 UTC 2019 x86_64 GNU/Linux
* **Subsystem**: http2

```js
const http2 = require('http2');

try {
    const session = http2.connect('https://example.com', {
        settings: {
            maxFrameSize: 1
        }
    });
    
    session.on('error', error => {
        console.log('Captured an error.');
    });
} catch (error) {
    console.log('Captured an error.');
}
```

[See it on RunKit.](https://runkit.com/szmarczak/5d3f399f2f4891001ab1616a)

### Actual behavior

```
internal/http2/util.js:521
      throw new ERR_HTTP2_INVALID_SETTING_VALUE.RangeError(
      ^

RangeError [ERR_HTTP2_INVALID_SETTING_VALUE]: Invalid value for setting "maxFrameSize": 1
    at ClientHttp2Session.settings (internal/http2/core.js:1156:5)
    at ClientHttp2Session.setupHandle (internal/http2/core.js:861:8)
    at Object.onceWrapper (events.js:291:20)
    at TLSSocket.emit (events.js:203:13)
    at TLSSocket.onConnectSecure (_tls_wrap.js:1346:10)
    at TLSSocket.emit (events.js:203:13)
    at TLSSocket._finishInit (_tls_wrap.js:792:8)
    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:606:12) {
  actual: 1,
  min: 16384,
  max: 16777215
}
```

### Expected behavior

```
Captured an error.
```

### Possible solution

It's thrown from here:

https://github.com/nodejs/node/blob/98d8ed64ff850a2a76685112886c22faa30e156d/lib/internal/http2/core.js#L975

I think it needs to be like:

```js
      socket.once(connectEvent, () => {
        try {
          setupFn();
        } catch (error) {
          socket.destroy(error);
        }
      });
```

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Some `http2` errors are not captured #28895

Actual behavior

Expected behavior

Possible solution

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Uh oh!

Some http2 errors are not captured #28895

Description

Actual behavior

Expected behavior

Possible solution

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Some `http2` errors are not captured #28895