-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Double keypress in readline / process.stdin #25875
Copy link
Copy link
Closed
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.readlineIssues and PRs related to the built-in readline module.Issues and PRs related to the built-in readline module.
Metadata
Metadata
Assignees
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.readlineIssues and PRs related to the built-in readline module.Issues and PRs related to the built-in readline module.
This code produces repeated output:
Run this with Node 11.8.0 or above and press the down arrow; two messages are produced:
Revert to Node 11.7.0, a single message is produced.
This breaks, among many things, scrolling through menus in Inquirer.js: SBoudrias/Inquirer.js#778
This appears to be Windows specific (as far as I could tell, I was only able to test on a Linux VM via Docker right now).
Git bisect tells me this issue first appeared with c0859d7, which upgraded
libuvto1.25.0.I'll keep digging into libuv (I already have an idea of where the problem was introduced in 1.25.0) but since this impacts Node on Windows somehwat significantly I figured it would be useful to have a way to track this!