-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Windows CI failures: parallel/test-trace-events-fs-sync #25512
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Seeing 3221225477 (access violation) non-stop on win10 + vs2017 on CI in a trace_events test:
Examples:
https://ci.nodejs.org/job/node-test-binary-windows/23086/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=0/console
https://ci.nodejs.org/job/node-test-binary-windows/23085/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=0/
https://ci.nodejs.org/job/node-test-binary-windows/23084/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=0/
...and many others...started happening in the last 24 hours or so. Not sure if something changed in our code or if something changed on CI or what. First noted (to my knowledge) by @gireeshpunathil in #22712 (comment) and #22865 (comment).
That was rebased onto 7f91329. So if the problem is in our code (and not something that is only being surfaced now but has been there for a while or else something that is a problem with the CI host and not a problem with the test or code), then it would be either in that commit or one shortly before it.
@nodejs/trace-events
[refack]Added context - the above 3 fails are on 3 different workers. AFAICT all failures are similar and happen while testing
fchmodTest call site: https://github.com/nodejs/node/blob/master/test/parallel/test-trace-events-fs-sync.js#L122
and setup site: https://github.com/nodejs/node/blob/master/test/parallel/test-trace-events-fs-sync.js#L33-L36
where this test case is six deep.