Abort when using --trace-events-enabled on test-http2-respond-with-file #19921

Activity

1. jasnell commented on Apr 10, 2018

   

   jasnell

   on Apr 10, 2018

   MemberAuthor

   More actions

   @addaleax ... appears to happen only with the respond-with-file tests
2. addaleax commented on Apr 10, 2018

   

   addaleax

   on Apr 10, 2018

   Member

   More actions

   Adding the handle scopes should be enough, I think?

   diff --git a/src/async_wrap-inl.h b/src/async_wrap-inl.h
   index c9f123332430..f9c709aa21e9 100644
   --- a/src/async_wrap-inl.h
   +++ b/src/async_wrap-inl.h
   @@ -50,6 +50,7 @@ inline AsyncWrap::AsyncScope::AsyncScope(AsyncWrap* wrap)
      Environment* env = wrap->env();
      if (env->async_hooks()->fields()[Environment::AsyncHooks::kBefore] == 0)
        return;
   +  v8::HandleScope handle_scope(env->isolate());
      EmitBefore(env, wrap->get_async_id());
    }
    
   @@ -57,6 +58,7 @@ inline AsyncWrap::AsyncScope::~AsyncScope() {
      Environment* env = wrap_->env();
      if (env->async_hooks()->fields()[Environment::AsyncHooks::kAfter] == 0)
        return;
   +  v8::HandleScope handle_scope(env->isolate());
      EmitAfter(env, wrap_->get_async_id());
    }
    
3. jasnell commented on Apr 10, 2018

   

   jasnell

   on Apr 10, 2018

   MemberAuthor

   More actions

   I think so, yes :-)
4. ryzokuken commented on Apr 11, 2018

   

   ryzokuken

   on Apr 11, 2018

   Contributor

   More actions

   @addaleax @jasnell do the above changes make it work perfectly? Should I submit a patch with them?
5. jasnell commented on Apr 11, 2018

   

   jasnell

   on Apr 11, 2018

   MemberAuthor

   More actions

   I haven't checked yet but it's simple to test :-)
6. ryzokuken

   added a commit that references this issue on Apr 12, 2018

   src: add HandleScope to fix error

   ...

   1797f65
7. jasnell

   closed this as completedin 6eaeabcon Apr 14, 2018
8. jasnell

   added a commit that references this issue on Apr 16, 2018

   src: add HandleScope to fix error

   ...

   80de830
9. sjarmak

   added a commit that references this issue on Jul 27, 2026

   src: add HandleScope to fix error

   ...

   6eaeabc