-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
tools: some eslint rules proposals #14253
Copy link
Copy link
Closed
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Metadata
Metadata
Assignees
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Recently some big PRs with churn was mostly rejected or gave sporadic -1, so these are some preliminarily proposals to check the opinions before investing time.
Rule: http://eslint.org/docs/rules/no-unused-vars
Proposal:
Hits:
Refs: tools: delete an unused argument #14251
Rule: http://eslint.org/docs/rules/prefer-arrow-callback
Proposal:
Hits:
Rule: http://eslint.org/docs/rules/prefer-destructuring
Proposal:
Hits:
If there is some consensus for any proposal, it can be used as a starting point for code-and-learn or similar events.
If some or all approved proposals are not appropriate for code-and-learn, I can do any or all if there are volunteers to review.