-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
test: define and test validity of core-dumps #14110
Copy link
Copy link
Closed
Labels
post-mortemIssues and PRs related to the post-mortem diagnostics of Node.js.Issues and PRs related to the post-mortem diagnostics of Node.js.processIssues and PRs related to the process subsystem.Issues and PRs related to the process subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Metadata
Metadata
Assignees
Labels
post-mortemIssues and PRs related to the post-mortem diagnostics of Node.js.Issues and PRs related to the post-mortem diagnostics of Node.js.processIssues and PRs related to the process subsystem.Issues and PRs related to the process subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.
The ad-hoc situation is that
nodehas incorporatedV8's--abort-on-uncaught-exceptionas a core feature (Ref: #14013).There seems to be a consensus forming to make this an explicit design decision and document it (Ref: #13931).
Currently the test suite only tests for process exit state (i.e.
codeandsignal) but does not do any testing on the validity of generated code-dump.I suggest we define the minimal requirements needed from the core-dump to be valid and find a way to automatically assert those.
/cc @nodejs/post-mortem @nodejs/testing @nodejs/release @nodejs/build