-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Type confusion bug in HTTP parser #12178
Copy link
Copy link
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
We found unchecked type cast in the HTTP parser code. This one is in https://github.com/nodejs/node/blob/master/src/node_http_parser.cc#L496
Here is the 3 line exploit:
Can also just modifying the example on the nodejs.org site to trigger bug with public API: