crypto: fix default encoding of LazyTransform

Lukas Möller · Lukas Möller · commit fe9de5d880ed · 2017-02-16T10:00:34.000+01:00
PullRequest #5522 and #5500 described the change of the default encoding into UTF8 in crypto functions. This however was only changed for the non-streaming API. The streaming API still used binary as the default encoding. This commit will change the default streaming API encoding to UTF8 to make both APIs behave the same. It will also add tests to validate the behavior.
diff --git a/test/parallel/test-crypto.js b/test/parallel/test-crypto.js
@@ -181,9 +181,9 @@ function testEncoding(options, assertionHash) {
     hashValue += data.toString('hex');
   });
 
-  hash.on('end', () => {
-    assert.equal(hashValue, assertionHash);
-  });
+  hash.on('end', common.mustCall(() => {
+    assert.strictEqual(hashValue, assertionHash);
+  }));
 
   hash.write('öäü');
   hash.end();
@@ -193,8 +193,8 @@ function testEncoding(options, assertionHash) {
 const assertionHashUtf8 =
   '4f53d15bee524f082380e6d7247cc541e7cb0d10c64efdcc935ceeb1e7ea345c';
 
-// Hash of "öäü" in ascii format
-const assertionHashAscii =
+// Hash of "öäü" in latin1 format
+const assertionHashLatin1 =
   'cd37bccd5786e2e76d9b18c871e919e6eb11cc12d868f5ae41c40ccff8e44830';
 
 testEncoding(undefined, assertionHashUtf8);
@@ -205,5 +205,5 @@ testEncoding({
 }, assertionHashUtf8);
 
 testEncoding({
-  defaultEncoding: 'ascii'
-}, assertionHashAscii);
+  defaultEncoding: 'latin1'
+}, assertionHashLatin1);
