stdio: call _undestroy() inside _destroy for stdout and stderr

mcollina · mcollina · commit fd985971ede9 · 2021-08-06T15:20:18.000+02:00
Fixes: #39447
diff --git a/lib/internal/bootstrap/switches/is_main_thread.js b/lib/internal/bootstrap/switches/is_main_thread.js
@@ -100,6 +100,7 @@ function createWritableStdioStream(fd) {
 
 function dummyDestroy(err, cb) {
   cb(err);
+  this._undestroy();
 
   // We need to emit 'close' anyway so that the closing
   // of the stream is observable. We just make sure we
diff --git a/test/parallel/test-stdio-undestroy.js b/test/parallel/test-stdio-undestroy.js
@@ -0,0 +1,29 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const spawn = require('child_process').spawn;
+const fs = require('fs');
+const fixtures = require('../common/fixtures');
+
+if (process.argv[2] === 'child') {
+  process.stdout.destroy()
+  console.log('out')
+  console.error('err')
+  return;
+}
+
+// Run the script in a shell but close stdout and stderr.
+const cmd = `"${process.execPath}" "${__filename}" child`;
+const proc = spawn('/bin/sh', ['-c', cmd], { stdio: 'pipe' });
+
+proc.stdout.on('data', common.mustCall(function(chunk) {
+  assert.strictEqual(chunk.toString(), 'out\n');
+}));
+
+proc.stderr.on('data', common.mustCall(function(chunk) {
+  assert.strictEqual(chunk.toString(), 'err\n');
+}));
+
+proc.on('exit', common.mustCall(function(exitCode) {
+  assert.strictEqual(exitCode, 0);
+}));
