src: guard against env != null in node_errors.cc

addaleax · addaleax · commit f3a7f815684a · 2020-12-06T16:41:56.000+01:00
Otherwise
`TriggerUncaughtException()`
→ `PrintException()`
→ `GetErrorSource()`
can crash.
diff --git a/src/node_errors.cc b/src/node_errors.cc
@@ -63,7 +63,7 @@ static std::string GetErrorSource(Isolate* isolate,
   Environment* env = Environment::GetCurrent(isolate);
   const bool has_source_map_url =
       !message->GetScriptOrigin().SourceMapUrl().IsEmpty();
-  if (has_source_map_url && env->source_maps_enabled()) {
+  if (has_source_map_url && env != nullptr && env->source_maps_enabled()) {
     return sourceline;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ static std::string GetErrorSource(Isolate* isolate,`
`63`	`63`	`Environment* env = Environment::GetCurrent(isolate);`
`64`	`64`	`const bool has_source_map_url =`
`65`	`65`	`!message->GetScriptOrigin().SourceMapUrl().IsEmpty();`
`66`		`- if (has_source_map_url && env->source_maps_enabled()) {`
	`66`	`+ if (has_source_map_url && env != nullptr && env->source_maps_enabled()) {`
`67`	`67`	`return sourceline;`
`68`	`68`	`}`
`69`	`69`