fixup! http: improve performance by removing async_hooks

JonasBa · JonasBa · commit ed5c1aa2ac2b · 2025-04-14T20:35:38.000-04:00
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -996,7 +996,7 @@ function resOnFinish(req, res, socket, state, server) {
   // If the user never called req.read(), and didn't pipe() or
   // .resume() or .on('data'), then we call req._dump() so that the
   // bytes will be pulled off the wire.
-  if (!req._consuming && !req._readableState.resumeScheduled)
+  if (!req._consuming && !req._readableState.resumeScheduled && !req._readableState.paused)
     req._dump();
 
   res.detachSocket(socket);
diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
@@ -464,10 +464,10 @@ class Parser : public BaseObject, public StreamListener {
 
     Local<Value> buffer = Buffer::Copy(env, at, length).ToLocalChecked();
 
-    MaybeLocal<Value> r =
-        cb.As<Function>()->Call(env->context(), object(), 1, &buffer);
+    v8::TryCatch try_catch(env->isolate());
+    USE(cb.As<Function>()->Call(env->context(), object(), 1, &buffer));
 
-    if (r.IsEmpty()) {
+    if (try_catch.HasCaught()) {
       got_exception_ = true;
       llhttp_set_error_reason(&parser_, "HPE_JS_EXCEPTION:JS Exception");
       return HPE_USER;
@@ -503,9 +503,11 @@ class Parser : public BaseObject, public StreamListener {
     if (!cb->IsFunction())
       return 0;
 
-    MaybeLocal<Value> r =
-        cb.As<Function>()->Call(env()->context(), object(), 0, nullptr);
-    if (r.IsEmpty()) {
+
+    v8::TryCatch try_catch(env()->isolate());
+    USE(cb.As<Function>()->Call(env()->context(), object(), 0, nullptr));
+
+    if (try_catch.HasCaught()) {
       got_exception_ = true;
       return -1;
     }
