Skip to content

Commit e9b0552

Browse files
committed
src: update NODE_MODULE_VERSION to 96
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 9.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #39469 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent d9df416 commit e9b0552

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

doc/abi_version_registry.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 96, "runtime": "node", "variant": "v8_9.3", "versions": "17.0.0-pre" },
34
{ "modules": 95, "runtime": "node", "variant": "v8_9.2", "versions": "17.0.0-pre" },
45
{ "modules": 94, "runtime": "node", "variant": "v8_9.1", "versions": "17.0.0-pre" },
56
{ "modules": 93, "runtime": "node", "variant": "v8_9.0", "versions": "16.0.0" },

src/node_version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
* version matching should open a pull request to reserve a number in this
9090
* registry.
9191
*/
92-
#define NODE_MODULE_VERSION 95
92+
#define NODE_MODULE_VERSION 96
9393

9494
// The NAPI_VERSION provided by this version of the runtime. This is the version
9595
// which the Node binary being built supports.

0 commit comments

Comments
 (0)