crypto: add new tests for the lazy-transform

zvictor · zvictor · commit e689066bf523 · 2016-09-17T14:02:22.000+02:00
diff --git a/lib/crypto.js b/lib/crypto.js
@@ -21,7 +21,7 @@ const timingSafeEqual = binding.timingSafeEqual;
 const Buffer = require('buffer').Buffer;
 const stream = require('stream');
 const util = require('util');
-const LazyTransform = require('internal/streams/lazy_transform');
+const LazyTransform = require('internal/crypto/lazy_transform');
 
 const DH_GENERATOR = 2;
 
diff --git a/node.gyp b/node.gyp
@@ -92,7 +92,7 @@
       'lib/internal/util.js',
       'lib/internal/v8_prof_polyfill.js',
       'lib/internal/v8_prof_processor.js',
-      'lib/internal/streams/lazy_transform.js',
+      'lib/internal/crypto/lazy_transform.js',
       'lib/internal/streams/BufferList.js',
       'deps/v8/tools/splaytree.js',
       'deps/v8/tools/codemap.js',
diff --git a/test/parallel/test-crypto-lazy-transform.js b/test/parallel/test-crypto-lazy-transform.js
@@ -0,0 +1,69 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+
+if (!common.hasCrypto) {
+  common.skip('missing crypto');
+  return;
+}
+
+const crypto = require('crypto');
+
+const UTF_INPUT = 'öäü';
+const TEST_CASES = [
+  {
+    options: undefined,
+    // Hash of "öäü" in default format (utf8)
+    output: '4f53d15bee524f082380e6d7247cc541e7cb0d10c64efdcc935ceeb1e7ea345c',
+  },
+  {
+    options: {},
+    // Hash of "öäü" in default format (utf8)
+    output: '4f53d15bee524f082380e6d7247cc541e7cb0d10c64efdcc935ceeb1e7ea345c',
+  },
+  {
+    options: {
+      defaultEncoding: 'latin1',
+    },
+    // Hash of "öäü" in latin1 format
+    output: 'cd37bccd5786e2e76d9b18c871e919e6eb11cc12d868f5ae41c40ccff8e44830',
+  },
+  {
+    options: {
+      defaultEncoding: 'utf8',
+    },
+    // Hash of "öäü" in utf8 format
+    output: '4f53d15bee524f082380e6d7247cc541e7cb0d10c64efdcc935ceeb1e7ea345c',
+  },
+  {
+    options: {
+      defaultEncoding: 'ascii',
+    },
+    // Hash of "öäü" in ascii format
+    output: 'cd37bccd5786e2e76d9b18c871e919e6eb11cc12d868f5ae41c40ccff8e44830',
+  },
+];
+
+for (const test of TEST_CASES) {
+  const hashValue = crypto.createHash('sha256')
+    .update(UTF_INPUT, test.options && test.options.defaultEncoding)
+    .digest('hex');
+
+  assert.equal(hashValue, test.output);
+}
+
+for (const test of TEST_CASES) {
+  const hash = crypto.createHash('sha256', test.options);
+  let hashValue = '';
+
+  hash.on('data', (data) => {
+    hashValue += data.toString('hex');
+  });
+
+  hash.on('end', common.mustCall(() => {
+    assert.equal(hashValue, test.output);
+  }));
+
+  hash.write(UTF_INPUT);
+  hash.end();
+}
diff --git a/test/parallel/test-crypto.js b/test/parallel/test-crypto.js
@@ -140,42 +140,3 @@ assert.throws(function() {
 
 // Make sure memory isn't released before being returned
 console.log(crypto.randomBytes(16));
-
-/**
- * Check if the stream function uses utf8 as a default encoding.
- **/
-
-function testEncoding(options, assertionHash) {
-  const hash = crypto.createHash('sha256', options);
-  let hashValue = '';
-
-  hash.on('data', (data) => {
-    hashValue += data.toString('hex');
-  });
-
-  hash.on('end', () => {
-    assert.equal(hashValue, assertionHash);
-  });
-
-  hash.write('öäü');
-  hash.end();
-}
-
-// Hash of "öäü" in utf8 format
-const assertionHashUtf8 =
-  '4f53d15bee524f082380e6d7247cc541e7cb0d10c64efdcc935ceeb1e7ea345c';
-
-// Hash of "öäü" in ascii format
-const assertionHashAscii =
-  'cd37bccd5786e2e76d9b18c871e919e6eb11cc12d868f5ae41c40ccff8e44830';
-
-testEncoding(undefined, assertionHashUtf8);
-testEncoding({}, assertionHashUtf8);
-
-testEncoding({
-  defaultEncoding: 'utf8'
-}, assertionHashUtf8);
-
-testEncoding({
-  defaultEncoding: 'ascii'
-}, assertionHashAscii);
