fixup: leverage TrackInlineField

gireeshpunathil · gireeshpunathil · commit db9edc184cbf · 2019-03-01T01:08:40.000-05:00
diff --git a/src/node_worker.h b/src/node_worker.h
@@ -53,6 +53,8 @@ class Worker : public AsyncWrap {
 
   void MemoryInfo(MemoryTracker* tracker) const override {
     tracker->TrackField("parent_port", parent_port_);
+    tracker->TrackInlineField(&thread_stopper_, "thread_stopper_");
+    tracker->TrackInlineField(&on_thread_finished_, "on_thread_finished_");
   }
 
   SET_MEMORY_INFO_NAME(Worker)
diff --git a/test/pummel/test-heapdump-worker.js b/test/pummel/test-heapdump-worker.js
@@ -9,8 +9,8 @@ const worker = new Worker('setInterval(() => {}, 100);', { eval: true });
 validateSnapshotNodes('Node / Worker', [
   {
     children: [
-      { node_name: 'Node / uv_async_t', edge_name: 'thread_exit_async' },
-      { node_name: 'Node / Environment', edge_name: 'env' },
+      { node_name: 'Node / AsyncRequest', edge_name: 'thread_stopper_' },
+      { node_name: 'Node / AsyncRequest', edge_name: 'on_thread_finished_' },
       { node_name: 'Node / MessagePort', edge_name: 'parent_port' },
       { node_name: 'Worker', edge_name: 'wrapped' }
     ]

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ class Worker : public AsyncWrap {`
`53`	`53`
`54`	`54`	`void MemoryInfo(MemoryTracker* tracker) const override {`
`55`	`55`	`tracker->TrackField("parent_port", parent_port_);`
	`56`	`+ tracker->TrackInlineField(&thread_stopper_, "thread_stopper_");`
	`57`	`+ tracker->TrackInlineField(&on_thread_finished_, "on_thread_finished_");`
`56`	`58`	`}`
`57`	`59`
`58`	`60`	`SET_MEMORY_INFO_NAME(Worker)`
Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@ const worker = new Worker('setInterval(() => {}, 100);', { eval: true });`
`9`	`9`	`validateSnapshotNodes('Node / Worker', [`
`10`	`10`	`{`
`11`	`11`	`children: [`
`12`		`- { node_name: 'Node / uv_async_t', edge_name: 'thread_exit_async' },`
`13`		`- { node_name: 'Node / Environment', edge_name: 'env' },`
	`12`	`+ { node_name: 'Node / AsyncRequest', edge_name: 'thread_stopper_' },`
	`13`	`+ { node_name: 'Node / AsyncRequest', edge_name: 'on_thread_finished_' },`
`14`	`14`	`{ node_name: 'Node / MessagePort', edge_name: 'parent_port' },`
`15`	`15`	`{ node_name: 'Worker', edge_name: 'wrapped' }`
`16`	`16`	`]`