fixup! inspector: implement --heap-prof

joyeecheung · joyeecheung · commit da3cfadf667c · 2019-05-20T11:57:57.000+02:00
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -292,7 +292,7 @@ added: REPLACEME
 > Stability: 1 - Experimental
 
 Specify the average sampling interval in bytes for the heap profiles generated
-by `--heap-prof`. The default is 32 * 1024 bytes.
+by `--heap-prof`. The default is 512 * 1024 bytes.
 
 ### `--heap-prof-name`
 <!-- YAML
diff --git a/doc/node.1 b/doc/node.1
@@ -158,7 +158,7 @@ will be placed.
 The average sampling interval in bytes for the heap profiles generated by
 .Fl -heap-prof .
 The default is
-.Sy 32 * 1024 .
+.Sy 512 * 1024 .
 .
 .It Fl -heap-prof-name
 File name of the V8 heap profile generated with
diff --git a/src/inspector_profiler.h b/src/inspector_profiler.h
@@ -115,7 +115,7 @@ class V8HeapProfilerConnection : public V8ProfilerConnection {
   void Start() override;
   void End() override;
 
-  const char* type() const override { return type_.c_str(); }
+  const char* type() const override { return "heap"; }
   bool ending() const override { return ending_; }
 
   std::string GetDirectory() const override;
@@ -125,7 +125,6 @@ class V8HeapProfilerConnection : public V8ProfilerConnection {
  private:
   std::unique_ptr<inspector::InspectorSession> session_;
   bool ending_ = false;
-  std::string type_ = "heap";
 };
 
 }  // namespace profiler
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -407,7 +407,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             &EnvironmentOptions::heap_prof_dir);
   AddOption("--heap-prof-interval",
             "specified sampling interval in bytes for the V8 heap "
-            "profile generated with --heap-prof. (default: 32 * 1024)",
+            "profile generated with --heap-prof. (default: 512 * 1024)",
             &EnvironmentOptions::heap_prof_interval);
 #endif  // HAVE_INSPECTOR
   AddOption("--redirect-warnings",
diff --git a/src/node_options.h b/src/node_options.h
@@ -118,7 +118,7 @@ class EnvironmentOptions : public Options {
   bool cpu_prof = false;
   std::string heap_prof_dir;
   std::string heap_prof_name;
-  static const uint64_t kDefaultHeapProfInterval = 32 * 1024;
+  static const uint64_t kDefaultHeapProfInterval = 512 * 1024;
   uint64_t heap_prof_interval = kDefaultHeapProfInterval;
   bool heap_prof = false;
 #endif  // HAVE_INSPECTOR

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ will be placed.`
`158`	`158`	`The average sampling interval in bytes for the heap profiles generated by`
`159`	`159`	`.Fl -heap-prof .`
`160`	`160`	`The default is`
`161`		`-.Sy 32 * 1024 .`
	`161`	`+.Sy 512 * 1024 .`
`162`	`162`	`.`
`163`	`163`	`.It Fl -heap-prof-name`
`164`	`164`	`File name of the V8 heap profile generated with`