Skip to content

Commit d9494c9

Browse files
committed
streams: pipeline with signal
Generators in pipeline must be able to be aborted or pipeline can deadlock.
1 parent 842554f commit d9494c9

36 files changed

Lines changed: 1207 additions & 540 deletions

.github/SUPPORT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ resources:
1616

1717
* [Questions tagged 'node.js' on Stack Overflow](https://stackoverflow.com/questions/tagged/node.js)
1818
* [#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) channel on the OpenJS Foundation Slack ([join here](https://slack-invite.openjsf.org/))
19-
* [#node.js channel on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
19+
* [#node.js channel on libera.chat](https://web.libera.chat?channels=node.js&uio=d4)
2020
* [Node.js Slack Community](https://node-js.slack.com/)
2121
* To register: [nodeslackers.com](https://www.nodeslackers.com/)
2222

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ release.
3838
<a href="doc/changelogs/CHANGELOG_V16.md#16.0.0">16.0.0</a><br/>
3939
</td>
4040
<td valign="top">
41-
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.17.0">14.17.0</a></b><br/>
41+
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.17.1">14.17.1</a></b><br/>
42+
<a href="doc/changelogs/CHANGELOG_V14.md#14.17.0">14.17.0</a><br/>
4243
<a href="doc/changelogs/CHANGELOG_V14.md#14.16.1">14.16.1</a><br/>
4344
<a href="doc/changelogs/CHANGELOG_V14.md#14.16.0">14.16.0</a><br/>
4445
<a href="doc/changelogs/CHANGELOG_V14.md#14.15.5">14.15.5</a><br/>

doc/api/crypto.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3863,7 +3863,7 @@ The supplied `callback` function is called with two arguments: `err` and
38633863
`derivedKey`. If an errors occurs while deriving the key, `err` will be set;
38643864
otherwise `err` will be `null`. The successfully generated `derivedKey` will
38653865
be passed to the callback as an {ArrayBuffer}. An error will be thrown if any
3866-
of the input aguments specify invalid values or types.
3866+
of the input arguments specify invalid values or types.
38673867

38683868
```mjs
38693869
const {
@@ -3911,7 +3911,7 @@ given `key`, `salt` and `info` are used with the `digest` to derive a key of
39113911

39123912
The successfully generated `derivedKey` will be returned as an {ArrayBuffer}.
39133913

3914-
An error will be thrown if any of the input aguments specify invalid values or
3914+
An error will be thrown if any of the input arguments specify invalid values or
39153915
types, or if the derived key cannot be generated.
39163916

39173917
```mjs

doc/api/deprecations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2502,7 +2502,7 @@ is flushed.
25022502
Use [`response.writableFinished`][] or [`response.writableEnded`][]
25032503
accordingly instead to avoid the ambiguity.
25042504

2505-
To maintain existing behaviour `response.finished` should be replaced with
2505+
To maintain existing behavior `response.finished` should be replaced with
25062506
`response.writableEnded`.
25072507

25082508
### DEP0137: Closing fs.FileHandle on garbage collection

doc/api/errors.md

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -717,12 +717,16 @@ STDERR/STDOUT, and the data's length is longer than the `maxBuffer` option.
717717
<a id="ERR_CLOSED_MESSAGE_PORT"></a>
718718
### `ERR_CLOSED_MESSAGE_PORT`
719719
<!--
720-
added: v16.2.0
720+
added:
721+
- v16.2.0
722+
- v14.17.1
721723
changes:
722724
- version: 11.12.0
723725
pr-url: https://github.com/nodejs/node/pull/26487
724726
description: The error message was removed.
725-
- version: v16.2.0
727+
- version:
728+
- v16.2.0
729+
- v14.17.1
726730
pr-url: https://github.com/nodejs/node/pull/38510
727731
description: The error message was reintroduced.
728732
-->
@@ -1003,6 +1007,22 @@ added: v15.0.0
10031007

10041008
An attempt to invoke an unsupported crypto operation was made.
10051009

1010+
<a id="ERR_DEBUGGER_ERROR"></a>
1011+
### `ERR_DEBUGGER_ERROR`
1012+
<!-- YAML
1013+
added: REPLACEME
1014+
-->
1015+
1016+
An error occurred with the [debugger][].
1017+
1018+
<a id="ERR_DEBUGGER_STARTUP_ERROR"></a>
1019+
### `ERR_DEBUGGER_STARTUP_ERROR`
1020+
<!-- YAML
1021+
added: REPLACEME
1022+
-->
1023+
1024+
The [debugger][] timed out waiting for the required host/port to be free.
1025+
10061026
<a id="ERR_DLOPEN_FAILED"></a>
10071027
### `ERR_DLOPEN_FAILED`
10081028
<!-- YAML
@@ -2828,6 +2848,7 @@ The native call from `process.cpuUsage` could not be processed.
28282848
[`util.getSystemErrorName(error.errno)`]: util.md#util_util_getsystemerrorname_err
28292849
[`zlib`]: zlib.md
28302850
[crypto digest algorithm]: crypto.md#crypto_crypto_gethashes
2851+
[debugger]: debugger.md
28312852
[define a custom subpath]: packages.md#packages_subpath_exports
28322853
[domains]: domain.md
28332854
[event emitter-based]: events.md#events_class_eventemitter

doc/api/http.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2318,7 +2318,9 @@ will result in a `TypeError` being thrown.
23182318
### `outgoingMessage.connection`
23192319
<!-- YAML
23202320
added: v0.3.0
2321-
deprecated: v15.12.0
2321+
deprecated:
2322+
- v15.12.0
2323+
- v14.17.1
23222324
-->
23232325

23242326
> Stability: 0 - Deprecated: Use [`outgoingMessage.socket`][] instead.

doc/api/http2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3843,7 +3843,7 @@ for instance).
38433843
The compatibility API falls back to `host` if `:authority` is not
38443844
present. See [`request.authority`][] for more information. However,
38453845
if you don't use the compatibility API (or use `req.headers` directly),
3846-
you need to implement any fall-back behaviour yourself.
3846+
you need to implement any fall-back behavior yourself.
38473847

38483848
[ALPN Protocol ID]: https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids
38493849
[ALPN negotiation]: #http2_alpn_negotiation

doc/api/n-api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5228,7 +5228,7 @@ avoid introducing causing memory leaks. However, if the `async_resource` is
52285228
garbage collected by JavaScript engine before the `napi_async_context` was
52295229
destroyed by `napi_async_destroy`, calling `napi_async_context` related APIs
52305230
like [`napi_open_callback_scope`][] and [`napi_make_callback`][] can cause
5231-
problems like loss of async context when using the `AsyncLocalStoage` API.
5231+
problems like loss of async context when using the `AsyncLocalStorage` API.
52325232

52335233
In order to retain ABI compatibility with previous versions, passing `NULL`
52345234
for `async_resource` does not result in an error. However, this is not
@@ -5731,7 +5731,7 @@ after receiving a return value of `napi_closing` in response to a call to
57315731
`napi_threadsafe_function` can be freed in its `napi_finalize` callback which
57325732
was passed to `napi_create_threadsafe_function()`. The parameter
57335733
`initial_thread_count` of `napi_create_threadsafe_function` marks the initial
5734-
number of aquisitions of the thread-safe functions, instead of calling
5734+
number of acquisitions of the thread-safe functions, instead of calling
57355735
`napi_acquire_threadsafe_function` multiple times at creation.
57365736

57375737
Once the number of threads making use of a `napi_threadsafe_function` reaches

0 commit comments

Comments
 (0)