fs: throw ERR_INVALID_THIS on illegal invocations

LiviaMedeiros · web-flow · commit d824914e61e0 · 2025-06-28T16:58:54.000Z
PR-URL: #58848 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/fs/dir.js b/lib/internal/fs/dir.js
@@ -18,6 +18,7 @@ const {
   codes: {
     ERR_DIR_CLOSED,
     ERR_DIR_CONCURRENT_OPERATION,
+    ERR_INVALID_THIS,
     ERR_MISSING_ARGS,
   },
 } = require('internal/errors');
@@ -67,6 +68,8 @@ class Dir {
   }
 
   get path() {
+    if (!(#path in this))
+      throw new ERR_INVALID_THIS('Dir');
     return this.#path;
   }
 
diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js
@@ -25,6 +25,7 @@ const {
   validateBoolean,
   validateFunction,
   validateInteger,
+  validateThisInternalField,
 } = require('internal/validators');
 const { errorOrDestroy } = require('internal/streams/destroy');
 const fs = require('fs');
@@ -230,9 +231,11 @@ ObjectSetPrototypeOf(ReadStream, Readable);
 ObjectDefineProperty(ReadStream.prototype, 'autoClose', {
   __proto__: null,
   get() {
+    validateThisInternalField(this, kFs, 'ReadStream');
     return this._readableState.autoDestroy;
   },
   set(val) {
+    validateThisInternalField(this, kFs, 'ReadStream');
     this._readableState.autoDestroy = val;
   },
 });
@@ -394,9 +397,11 @@ ObjectSetPrototypeOf(WriteStream, Writable);
 ObjectDefineProperty(WriteStream.prototype, 'autoClose', {
   __proto__: null,
   get() {
+    validateThisInternalField(this, kFs, 'WriteStream');
     return this._writableState.autoDestroy;
   },
   set(val) {
+    validateThisInternalField(this, kFs, 'WriteStream');
     this._writableState.autoDestroy = val;
   },
 });
diff --git a/test/parallel/test-fs-opendir.js b/test/parallel/test-fs-opendir.js
@@ -18,6 +18,13 @@ files.forEach(function(filename) {
   fs.closeSync(fs.openSync(path.join(testDir, filename), 'w'));
 });
 
+function assertDir(dir) {
+  assert(dir instanceof fs.Dir);
+  assert.throws(() => dir.constructor.prototype.path, {
+    code: 'ERR_INVALID_THIS',
+  });
+}
+
 function assertDirent(dirent) {
   assert(dirent instanceof fs.Dirent);
   assert.strictEqual(dirent.isFile(), true);
@@ -45,6 +52,7 @@ const invalidCallbackObj = {
 // Check the opendir Sync version
 {
   const dir = fs.opendirSync(testDir);
+  assertDir(dir);
   const entries = files.map(() => {
     const dirent = dir.readSync();
     assertDirent(dirent);
@@ -67,6 +75,7 @@ const invalidCallbackObj = {
 
 // Check the opendir async version
 fs.opendir(testDir, common.mustSucceed((dir) => {
+  assertDir(dir);
   let sync = true;
   dir.read(common.mustSucceed((dirent) => {
     assert(!sync);
@@ -120,6 +129,7 @@ fs.opendir(__filename, common.mustCall(function(e) {
 async function doPromiseTest() {
   // Check the opendir Promise version
   const dir = await fs.promises.opendir(testDir);
+  assertDir(dir);
   const entries = [];
 
   let i = files.length;
diff --git a/test/parallel/test-fs-write-stream-autoclose-option.js b/test/parallel/test-fs-write-stream-autoclose-option.js
@@ -56,3 +56,7 @@ function next3() {
     }));
   }));
 }
+
+assert.throws(() => fs.WriteStream.prototype.autoClose, {
+  code: 'ERR_INVALID_THIS',
+});

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ const {`
`18`	`18`	`codes: {`
`19`	`19`	`ERR_DIR_CLOSED,`
`20`	`20`	`ERR_DIR_CONCURRENT_OPERATION,`
	`21`	`+ ERR_INVALID_THIS,`
`21`	`22`	`ERR_MISSING_ARGS,`
`22`	`23`	`},`
`23`	`24`	`} = require('internal/errors');`
`@@ -67,6 +68,8 @@ class Dir {`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`get path() {`
	`71`	`+ if (!(#path in this))`
	`72`	`+ throw new ERR_INVALID_THIS('Dir');`
`70`	`73`	`return this.#path;`
`71`	`74`	`}`
`72`	`75`
Original file line number	Diff line number	Diff line change
`@@ -56,3 +56,7 @@ function next3() {`
`56`	`56`	`}));`
`57`	`57`	`}));`
`58`	`58`	`}`
	`59`	`+`
	`60`	`+assert.throws(() => fs.WriteStream.prototype.autoClose, {`
	`61`	`+ code: 'ERR_INVALID_THIS',`
	`62`	`+});`