timers: fix binding fast call signatures

Renegade334 · targos · commit d7285459fec6 · 2025-10-06T16:17:35.000+02:00
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/timers.cc b/src/timers.cc
@@ -53,9 +53,8 @@ void BindingData::SlowScheduleTimer(const FunctionCallbackInfo<Value>& args) {
   }
 }
 
-void BindingData::FastScheduleTimer(Local<Object> unused,
-                                    Local<Object> receiver,
-                                    int64_t duration) {
+void BindingData::FastScheduleTimer(Local<Object> receiver, int64_t duration) {
+  TRACK_V8_FAST_API_CALL("timers.scheduleTimer");
   ScheduleTimerImpl(FromJSObject<BindingData>(receiver), duration);
 }
 
@@ -69,9 +68,8 @@ void BindingData::SlowToggleTimerRef(
                      args[0]->IsTrue());
 }
 
-void BindingData::FastToggleTimerRef(Local<Object> unused,
-                                     Local<Object> receiver,
-                                     bool ref) {
+void BindingData::FastToggleTimerRef(Local<Object> receiver, bool ref) {
+  TRACK_V8_FAST_API_CALL("timers.toggleTimerRef");
   ToggleTimerRefImpl(FromJSObject<BindingData>(receiver), ref);
 }
 
@@ -85,9 +83,8 @@ void BindingData::SlowToggleImmediateRef(
                          args[0]->IsTrue());
 }
 
-void BindingData::FastToggleImmediateRef(Local<Object> unused,
-                                         Local<Object> receiver,
-                                         bool ref) {
+void BindingData::FastToggleImmediateRef(Local<Object> receiver, bool ref) {
+  TRACK_V8_FAST_API_CALL("timers.toggleImmediateRef");
   ToggleImmediateRefImpl(FromJSObject<BindingData>(receiver), ref);
 }
 
diff --git a/src/timers.h b/src/timers.h
@@ -31,23 +31,18 @@ class BindingData : public SnapshotableObject {
 
   static void SlowScheduleTimer(
       const v8::FunctionCallbackInfo<v8::Value>& args);
-  static void FastScheduleTimer(v8::Local<v8::Object> unused,
-                                v8::Local<v8::Object> receiver,
+  static void FastScheduleTimer(v8::Local<v8::Object> receiver,
                                 int64_t duration);
   static void ScheduleTimerImpl(BindingData* data, int64_t duration);
 
   static void SlowToggleTimerRef(
       const v8::FunctionCallbackInfo<v8::Value>& args);
-  static void FastToggleTimerRef(v8::Local<v8::Object> unused,
-                                 v8::Local<v8::Object> receiver,
-                                 bool ref);
+  static void FastToggleTimerRef(v8::Local<v8::Object> receiver, bool ref);
   static void ToggleTimerRefImpl(BindingData* data, bool ref);
 
   static void SlowToggleImmediateRef(
       const v8::FunctionCallbackInfo<v8::Value>& args);
-  static void FastToggleImmediateRef(v8::Local<v8::Object> unused,
-                                     v8::Local<v8::Object> receiver,
-                                     bool ref);
+  static void FastToggleImmediateRef(v8::Local<v8::Object> receiver, bool ref);
   static void ToggleImmediateRefImpl(BindingData* data, bool ref);
 
   static void CreatePerIsolateProperties(IsolateData* isolate_data,
diff --git a/test/parallel/test-timers-fast-calls.js b/test/parallel/test-timers-fast-calls.js
@@ -0,0 +1,28 @@
+// Flags: --allow-natives-syntax --expose-internals --no-warnings
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+
+const { internalBinding } = require('internal/test/binding');
+const binding = internalBinding('timers');
+
+function testFastCalls() {
+  binding.scheduleTimer(1);
+  binding.toggleTimerRef(true);
+  binding.toggleTimerRef(false);
+  binding.toggleImmediateRef(true);
+  binding.toggleImmediateRef(false);
+}
+
+eval('%PrepareFunctionForOptimization(testFastCalls)');
+testFastCalls();
+eval('%OptimizeFunctionOnNextCall(testFastCalls)');
+testFastCalls();
+
+if (common.isDebug) {
+  const { getV8FastApiCallCount } = internalBinding('debug');
+  assert.strictEqual(getV8FastApiCallCount('timers.scheduleTimer'), 1);
+  assert.strictEqual(getV8FastApiCallCount('timers.toggleTimerRef'), 2);
+  assert.strictEqual(getV8FastApiCallCount('timers.toggleImmediateRef'), 2);
+}

Original file line number	Diff line number	Diff line change
`@@ -53,9 +53,8 @@ void BindingData::SlowScheduleTimer(const FunctionCallbackInfo<Value>& args) {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`-void BindingData::FastScheduleTimer(Local<Object> unused,`
`57`		`- Local<Object> receiver,`
`58`		`- int64_t duration) {`
	`56`	`+void BindingData::FastScheduleTimer(Local<Object> receiver, int64_t duration) {`
	`57`	`+ TRACK_V8_FAST_API_CALL("timers.scheduleTimer");`
`59`	`58`	`ScheduleTimerImpl(FromJSObject<BindingData>(receiver), duration);`
`60`	`59`	`}`
`61`	`60`
`@@ -69,9 +68,8 @@ void BindingData::SlowToggleTimerRef(`
`69`	`68`	`args[0]->IsTrue());`
`70`	`69`	`}`
`71`	`70`
`72`		`-void BindingData::FastToggleTimerRef(Local<Object> unused,`
`73`		`- Local<Object> receiver,`
`74`		`- bool ref) {`
	`71`	`+void BindingData::FastToggleTimerRef(Local<Object> receiver, bool ref) {`
	`72`	`+ TRACK_V8_FAST_API_CALL("timers.toggleTimerRef");`
`75`	`73`	`ToggleTimerRefImpl(FromJSObject<BindingData>(receiver), ref);`
`76`	`74`	`}`
`77`	`75`
`@@ -85,9 +83,8 @@ void BindingData::SlowToggleImmediateRef(`
`85`	`83`	`args[0]->IsTrue());`
`86`	`84`	`}`
`87`	`85`
`88`		`-void BindingData::FastToggleImmediateRef(Local<Object> unused,`
`89`		`- Local<Object> receiver,`
`90`		`- bool ref) {`
	`86`	`+void BindingData::FastToggleImmediateRef(Local<Object> receiver, bool ref) {`
	`87`	`+ TRACK_V8_FAST_API_CALL("timers.toggleImmediateRef");`
`91`	`88`	`ToggleImmediateRefImpl(FromJSObject<BindingData>(receiver), ref);`
`92`	`89`	`}`
`93`	`90`