Skip to content

Commit ccf4ee4

Browse files
committed
http2: fix hanging of Http2ServerResponse's end method with no data
Fixes: #38258
1 parent 26e318a commit ccf4ee4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/internal/http2/compat.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -757,9 +757,6 @@ class Http2ServerResponse extends Stream {
757757
if (chunk !== null && chunk !== undefined)
758758
this.write(chunk, encoding);
759759

760-
state.headRequest = stream.headRequest;
761-
state.ending = true;
762-
763760
if (typeof cb === 'function') {
764761
if (stream.writableEnded)
765762
this.once('finish', cb);
@@ -770,6 +767,9 @@ class Http2ServerResponse extends Stream {
770767
if (!stream.headersSent)
771768
this.writeHead(this[kState].statusCode);
772769

770+
state.headRequest = stream.headRequest;
771+
state.ending = true;
772+
773773
if (this[kState].closed || stream.destroyed)
774774
ReflectApply(onStreamCloseResponse, stream, []);
775775
else

0 commit comments

Comments
 (0)