accept and ignore values above TIMEOUT_MAX

aduh95 · aduh95 · commit c2a91f205836 · 2022-07-16T09:24:40.000+02:00
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -139,8 +139,10 @@ class Test extends AsyncResource {
     }
 
     if (timeout != null && timeout !== Infinity) {
-      validateNumber(timeout, 'options.timeout', 0, TIMEOUT_MAX);
-      this.timeout = timeout;
+      validateNumber(timeout, 'options.timeout', 0);
+      if (timeout < TIMEOUT_MAX) {
+        this.timeout = timeout;
+      }
     }
 
     if (testOnlyFlag && !this.only) {
diff --git a/test/parallel/test-runner-option-validation.js b/test/parallel/test-runner-option-validation.js
@@ -6,10 +6,10 @@ const test = require('node:test');
 [Symbol(), {}, [], () => {}, 1n, true, '1'].forEach((timeout) => {
   assert.throws(() => test({ timeout }), { code: 'ERR_INVALID_ARG_TYPE' });
 });
-[-1, 2 ** 33, -Infinity, NaN].forEach((timeout) => {
+[-1, -Infinity, NaN].forEach((timeout) => {
   assert.throws(() => test({ timeout }), { code: 'ERR_OUT_OF_RANGE' });
 });
-[null, undefined, Infinity, 0, 1, 1.1].forEach((timeout) => {
+[null, undefined, Infinity, 0, 1, 1.1, 2 ** 33].forEach((timeout) => {
   // Valid values should not throw.
   test({ timeout });
 });

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,10 @@ class Test extends AsyncResource {`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`if (timeout != null && timeout !== Infinity) {`
`142`		`- validateNumber(timeout, 'options.timeout', 0, TIMEOUT_MAX);`
`143`		`- this.timeout = timeout;`
	`142`	`+ validateNumber(timeout, 'options.timeout', 0);`
	`143`	`+ if (timeout < TIMEOUT_MAX) {`
	`144`	`+ this.timeout = timeout;`
	`145`	`+ }`
`144`	`146`	`}`
`145`	`147`
`146`	`148`	`if (testOnlyFlag && !this.only) {`