test: added the requireStack to loader.js

mertcanaltin · mertcanaltin · commit bb572d54f3ed · 2023-03-13T12:42:46.000+03:00
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -459,7 +459,15 @@ function tryPackage(requestPath, exts, isMain, originalPath) {
       err.code = 'MODULE_NOT_FOUND';
       err.path = path.resolve(requestPath, 'package.json');
       err.requestPath = originalPath;
-      // TODO(BridgeAR): Add the requireStack as well.
+      const requireStack = [];
+      for (let cursor = module.parent;
+        cursor;
+        cursor = moduleParentCache.get(cursor)) {
+        ArrayPrototypePush(requireStack, cursor.filename || cursor.id);
+      }
+      if (requireStack.length > 0) {
+        err.requireStack = requireStack;
+      }
       throw err;
     } else {
       const jsonPath = path.resolve(requestPath, 'package.json');
diff --git a/test/parallel/test-require-package-errors.js b/test/parallel/test-require-package-errors.js
@@ -0,0 +1,24 @@
+'use strict';
+
+require('../common');
+
+const assert = require('assert');
+const path = require('path');
+const fs = require('fs');
+const tmpdir = require('../common/tmpdir');
+
+tmpdir.refresh();
+
+fs.writeFileSync(path.join(tmpdir.path, 'index.js'), 'require("a");');
+fs.mkdirSync(path.join(tmpdir.path, 'node_modules'));
+fs.mkdirSync(path.join(tmpdir.path, 'node_modules/a'));
+fs.mkdirSync(path.join(tmpdir.path, 'node_modules/b'));
+fs.writeFileSync(path.join(tmpdir.path, 'node_modules/a/a.js'), 'require("b");');
+fs.writeFileSync(path.join(tmpdir.path, 'node_modules/a/package.json'), '{ "main": "a.js" }');
+fs.writeFileSync(path.join(tmpdir.path, 'node_modules/b/package.json'), '{ "main": "b.js" }');
+
+assert.throws(() => {
+  require(path.join(tmpdir.path, 'index.js'));
+}, {
+  requireStack: ['/path/to/tmpdir/node_modules/a/a.js', '/path/to/tmpdir/index.js'],
+});
